Skip to content

Make kaocha.jit/jit thread-safe#453

Open
frenchy64 wants to merge 1 commit into
lambdaisland:mainfrom
frenchy64:require-lock
Open

Make kaocha.jit/jit thread-safe#453
frenchy64 wants to merge 1 commit into
lambdaisland:mainfrom
frenchy64:require-lock

Conversation

@frenchy64

Copy link
Copy Markdown
Contributor

Ensures we don't race with other requiring threads.

Note this is now safer than requiring-resolve (as of Clojure 1.12), which has a race condition making it prone to returning a partially initialized var.

@alysbrooks

Copy link
Copy Markdown
Member

The warning isn't a big deal either way, but I did look into the popularity of older Clojure versions, and 1.10 was already being phased out in 2022: https://clojure.org/news/2024/12/02/state-of-clojure-2024.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.15%. Comparing base (15e553d) to head (a5de958).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
- Coverage   69.17%   69.15%   -0.02%     
==========================================
  Files          52       52              
  Lines        2819     2824       +5     
  Branches      187      189       +2     
==========================================
+ Hits         1950     1953       +3     
- Misses        689      690       +1     
- Partials      180      181       +1     
Flag Coverage Δ
unit 69.15% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants