Skip to content

Fix/strict syntax default #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-messer wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Fix/strict syntax default #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50b58ed
Made strict_syntax false by default
m-messer Apr 16, 2026
f919293
Merge branch 'main' into fix/strict_syntax_default
m-messer May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/docs/user.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ If `strict_syntax` is set to true then the answer and response must have `*` or

If `strict_syntax` is set to false, then `*` can be omitted and `^` used instead of `**`. In this case it is also recommended to list any multicharacter symbols expected to appear in the response as input symbols.

By default `strict_syntax` is set to true.
By default `strict_syntax` is set to false.

#### `symbol_assumptions`

Expand Down
2 changes: 1 addition & 1 deletion app/evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def evaluation_function(response, answer, params, include_test_data=False) -> di
)

# FIXME: Move this into expression_utilities
if params.get("strict_syntax", True):
if params.get("strict_syntax", False):
if "^" in response:
evaluation_result.add_feedback(("NOTATION_WARNING_EXPONENT", symbolic_comparison_internal_messages("NOTATION_WARNING_EXPONENT")(dict())))
if "!" in response:
Expand Down
2 changes: 1 addition & 1 deletion app/utility/expression_utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ def create_sympy_parsing_params(params, unsplittable_symbols=tuple(), symbol_ass

symbol_dict.update(sympy_symbols(unsplittable_symbols))

strict_syntax = params.get("strict_syntax", True)
strict_syntax = params.get("strict_syntax", False)

parsing_params = {
"unsplittable_symbols": unsplittable_symbols,
Expand Down
Loading