Add static skill workflow pane#80
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 077d69ce8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const applyOutput = await applyDeployYaml({ | ||
| namespace: task.namespace, | ||
| runtimeName: runtime.name, | ||
| yaml: preparedArtifacts.yaml, | ||
| }); |
There was a problem hiding this comment.
Honor cancellation before applying generated resources
When a task is cancelled while the background runner is already executing, cancelDeployTask only flips the database status; this runner path never re-reads the task before applying the generated YAML and later writing completed/failed. In that scenario a DELETE request or cancelDeployTask tool call can still allow kubectl apply to run and then overwrite the cancelled status, so cancellation does not actually stop the deployment. Please guard for cancelled before apply/terminal updates or abort the gateway/runtime work.
Useful? React with 👍 / 👎.
| await updateDeployTaskState(input.taskId, { | ||
| gatewayThreadId: state.threadId ?? null, | ||
| gatewayTurnId: state.currentTurnId ?? null, | ||
| status: state.activeTurn === false ? "blocked" : "running", | ||
| }); |
There was a problem hiding this comment.
Preserve terminal statuses on gateway state events
If the gateway stream emits a late or replayed state event after the runner has already marked a task completed, failed, or cancelled, this unconditional update changes the task back to blocked (or running when activeTurn is truthy). Because the /events route persists every proxied state independently of the runner, simply watching the stream can regress a terminal task status; gate this update on the current task status or avoid status writes for terminal tasks.
Useful? React with 👍 / 👎.
077d69c to
7acffaf
Compare
Summary
Test Plan