Skip to content

Add static skill workflow pane#80

Open
Che-Zhu wants to merge 1 commit into
labring:mainfrom
Che-Zhu:codex/skill-static-display
Open

Add static skill workflow pane#80
Che-Zhu wants to merge 1 commit into
labring:mainfrom
Che-Zhu:codex/skill-static-display

Conversation

@Che-Zhu
Copy link
Copy Markdown

@Che-Zhu Che-Zhu commented May 29, 2026

Summary

  • add a Skill action beside the existing GitHub, Docker, and Database chat actions
  • wire the Skill intent into the project list and project canvas side pane flow
  • replace the static Skill pane content with the Sealos Skills workflow layout from the design

Test Plan

  • bun typecheck
  • bun test apps/ui/src/components/skill-library-pane.test.tsx packages/ui/src/components/chat/chat.input.test.tsx apps/ui/src/lib/project-canvas/panels/project-canvas-side-pane-slot.test.ts apps/ui/src/lib/project-side-pane/surface-intents.test.ts
  • bunx ultracite check packages/ui/src/components/chat/chat.input.tsx packages/ui/src/components/chat/chat.tsx packages/ui/src/components/chat/chat.input.test.tsx apps/ui/src/components/skill-library-pane.tsx apps/ui/src/components/skill-library-pane.test.tsx apps/ui/src/components/project-workspace-layout.tsx apps/ui/src/app/project/page.tsx 'apps/ui/src/app/project/[uid]/page.tsx' apps/ui/src/lib/project-side-pane/controller.ts apps/ui/src/lib/project-side-pane/surface-intents.ts apps/ui/src/lib/project-side-pane/surface-intents.test.ts apps/ui/src/lib/project-canvas/panels/project-canvas-side-pane-slot.tsx apps/ui/src/lib/project-canvas/panels/project-canvas-side-pane-slot.test.ts

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 077d69ce8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +600 to +604
const applyOutput = await applyDeployYaml({
namespace: task.namespace,
runtimeName: runtime.name,
yaml: preparedArtifacts.yaml,
});
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Honor cancellation before applying generated resources

When a task is cancelled while the background runner is already executing, cancelDeployTask only flips the database status; this runner path never re-reads the task before applying the generated YAML and later writing completed/failed. In that scenario a DELETE request or cancelDeployTask tool call can still allow kubectl apply to run and then overwrite the cancelled status, so cancellation does not actually stop the deployment. Please guard for cancelled before apply/terminal updates or abort the gateway/runtime work.

Useful? React with 👍 / 👎.

Comment on lines +333 to +337
await updateDeployTaskState(input.taskId, {
gatewayThreadId: state.threadId ?? null,
gatewayTurnId: state.currentTurnId ?? null,
status: state.activeTurn === false ? "blocked" : "running",
});
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve terminal statuses on gateway state events

If the gateway stream emits a late or replayed state event after the runner has already marked a task completed, failed, or cancelled, this unconditional update changes the task back to blocked (or running when activeTurn is truthy). Because the /events route persists every proxied state independently of the runner, simply watching the stream can regress a terminal task status; gate this update on the current task status or avoid status writes for terminal tasks.

Useful? React with 👍 / 👎.

@Che-Zhu Che-Zhu force-pushed the codex/skill-static-display branch from 077d69c to 7acffaf Compare May 29, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant