fix(build): do not treat a dependency stylesheet as one of this package's - #5
Merged
Merged
Conversation
…ge's A bare specifier resolves to a path inside the package root, so the check that was meant to leave dependency stylesheets alone never fired. Nothing here imports one today, which is why it went unnoticed; the sibling package hit it immediately with katex. The specifier form now decides, so only relative and absolute paths are re-linked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bare specifier such as
katex/dist/katex.min.cssresolves to a path inside the package root, so the check that was meant to leave dependency stylesheets alone never fired and the build would stop on a stylesheet it was never meant to re-link.Nothing here imports one today, which is why it went unnoticed.
lablup/ui-ai#1hit it immediately while taking the same fix, and this keeps the two builds identical rather than letting one carry a correction the other lacks.The specifier form now decides, so only relative and absolute paths are re-linked.
pnpm run verifygreen, packed artifact unchanged at 140 files. Release as0.1.0-alpha.5.