feat(empty-state): export the illustrations - #3
Merged
Conversation
The ten illustration components shipped inside the package from the first release, but no barrel named them, so nothing outside the package could reach one. `EmptyState` covers the common case; a consumer that composes its own empty state, with the illustration beside other content rather than above a title and description, had to keep a copy. That is the same shape as the stylesheets fixed in 0.1.0-alpha.1: present in the tarball, addressable by nothing. It surfaced the same way too, when a consumer's migration hit a name the package has and does not expose. `IllustrationProps` goes with them so a wrapper can be typed without redeclaring it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Exports the ten
EmptyStateillustrations, plusIllustrationProps.They have shipped inside every release, but no barrel named them, so nothing outside the package could reach one:
exportsoffers./components/EmptyState, that barrel exported onlyEmptyStateand its types, and there is no path toillustrations.js.Same shape as the stylesheets in 0.1.0-alpha.1: present in the tarball, addressable by nothing. It surfaced the same way too, when a consumer's migration reached a name the package has and does not expose.
EmptyStatecovers the common case, but a consumer that composes its own empty state, with the illustration beside other content rather than above a title and description, had to keep its own copy of the SVG.Verification
pnpm run verifygreen. Packed file count unchanged at 140: nothing new ships, a door opens on what already shipped.Release as
0.1.0-alpha.3.