feat: docker variant pull + end-to-end test harness - #5
Merged
Conversation
pull fetches the variant index, resolves system properties (real detection or --properties-file), ranks compatible variants, and pulls the best match by digest, tagging the result as both the base tag and the selected variant tag (ADR-6). Missing index or no compatible variant falls back to the plain base tag with a notice (the null variant, when indexed, is preferred over that fallback by construction); --no-fallback makes those cases hard errors and --dry-run prints the full ranking without pulling. e2e/run.sh exercises the whole loop against a disposable registry:2: variant pushes, plain-push + index update reconciliation, selection under three mocked hardware profiles (asserted via the variant label of the locally tagged result), dry-run, fallback, and --no-fallback. Wired into CI as a second job and `make e2e`. Claude-Session: https://claude.ai/code/session_01D383U8kkQkJc1yzyC5H5Nk
grep -q exits on the first match; if the plugin is still writing its ranking output, the write hits a closed pipe, Go's runtime raises SIGPIPE for stdout, and with pipefail the whole check fails. Capture the output first, as the fallback check already does. Claude-Session: https://claude.ai/code/session_01D383U8kkQkJc1yzyC5H5Nk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked PR 5/7 (base: #4). Completes the client-side story: variant-aware pull.
docker variant pull REGISTRY/REPO:VERSION: fetch index → detect (or--properties-file) → rank →docker pullby digest → tag as both the base tag and the selected variant tag (ADR-6).--no-fallbackturns fallbacks into errors;--dry-runprints the ranked candidates and the would-be pull.e2e/run.sh,make e2e, new CI job): disposableregistry:2; three variants (cu128/cu126 viavariant push, null via plaindocker push+index updatereconciliation); pull assertions under mocked CUDA-12.8, CUDA-12.6, and CPU-only profiles (verified by inspecting the variant label of what the base tag points to locally); dry-run, missing-index fallback, and--no-fallbackfailure.Test results
./e2e/run.shpasses locally end-to-end (all three hardware profiles select the expected variant; fallback and error paths behave). Unit tests and vet unchanged-green.https://claude.ai/code/session_01D383U8kkQkJc1yzyC5H5Nk