fix: parse the renamed CUDA UMD Version label in nvidia-smi banners - #11
Merged
Conversation
Drivers of the CUDA 13.3 generation (610.x) renamed the banner label from "CUDA Version" to "CUDA UMD Version", so the nvidia provider failed with "could not find CUDA version in nvidia-smi output". Match both labels and extend knownCUDAVersions with 13.2 and 13.3. Claude-Session: https://claude.ai/code/session_01EPVqgoDSoJ5Xx3jZ6d1AbX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvidia-smibanner label fromCUDA VersiontoCUDA UMD Version(the old label survives only innvidia-smi -q, marked deprecated for removal in CUDA 14.0). The nvidia provider's regex no longer matched, sodocker variant detectwarned withprovider nvidia: could not find CUDA version in nvidia-smi output.CUDA (?:UMD )?Version:and extendknownCUDAVersionswith 13.2 and 13.3.Testing
TestParseNvidiaSMIcase with a real 610.57.04 banner;go test ./pkg/providers/passes.make install-plugin && docker variant detectnow reportsnvidia :: cuda_version_lower_bound :: 13.3,...,11.0without warnings.https://claude.ai/code/session_01EPVqgoDSoJ5Xx3jZ6d1AbX