agentwrapper: Allow specyfing Python executable#1782
agentwrapper: Allow specyfing Python executable#1782steelman wants to merge 1 commit intolabgrid-project:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1782 +/- ##
======================================
Coverage 45.1% 45.1%
======================================
Files 172 172
Lines 13608 13609 +1
======================================
+ Hits 6144 6145 +1
Misses 7464 7464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Enable users to choose which Python executable to use to run the agent by setting LG_AGENT_PYTHON environment variable. This is necessary when a remote labgrid runs in a virtual environment which provide packages, or their versions, not available in the system installation of Python. Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
1c93807 to
5772c7e
Compare
|
Doesn't this mean that the same path would be used for all exporters? When you have a diverse set of exporters, a fixed interpreter wouldn't work well. |
|
I haven't thought about connecting to many different exporters at once, indeed. In such case, I suppose, each exporter should advertise the interpreter it uses and clients need to discover it. |
|
For which dependencies do you need a virtualenv? We've tried to avoid complex dependencies, so (in our setups) installing the few needed dependencies using distro packages worked well. Especially for NetworkManager, you want to use the packages which match the libnm from the distro. |
Description
Enable users to choose which Python executable to use to run the agent by setting LG_AGENT_PYTHON environment variable. This is necessary when a remote labgrid runs in a virtual environment which provide packages, or their versions, not available in the system installation of Python.
Checklist