feat: implement dark mode for scrollbars#516
Open
effessdev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
The scrollbars didn't change color when we toggled dark mode.
After
Now the scrollbar correctly changes to dark mode when dark mode is toggled on.
Implementation
Added custom scrollbar styles to
src/styles/index.cssfile.Another small adjustment
Previously, there was an absolutely positioned separator in the sidebar that was only visible in dark mode:
However, when we scroll down, it cuts off midway:
Since it was completely invisible in light mode (see the screenshot below), I thought it would be better if I removed it instead of fixing it for consistency. It was only three lines of code, so not a big problem.
Light mode:
Removed lines:
Verifications