Conversation
code_breaker/kameda/codebreaker.rb
Outdated
Member
There was a problem hiding this comment.
ネームスペースとして使うなら module の方が向いているように思います。(他に理由があったらごめんなさい。)
Author
There was a problem hiding this comment.
確かにそうかも!
僕は特にこだわりなく、クラスにしてしまいます。
Member
There was a problem hiding this comment.
なんとなくRuby界隈ではネームスペースにmoduleを使う文化があるように思うのですが、この辺りは好みなのかもですね。
real_hit_count = total_hit_count - match_count で求めるようにした。
total_hit_countを書きなおした
Author
|
ひどい感じだったところを書き直しました。
|
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
回答書きました。レビューお願いします！