Allow selecting an alternative default database with postgres#640
Open
georgepstaylor wants to merge 14 commits intokvesteri:masterfrom
Open
Allow selecting an alternative default database with postgres#640georgepstaylor wants to merge 14 commits intokvesteri:masterfrom
georgepstaylor wants to merge 14 commits intokvesteri:masterfrom
Conversation
Collaborator
|
@georgepstaylor It looks like your system may have run black against the file when you made changes to it (black is not yet used for code linting, but may be introduced in the future). For now, this has made the functional changes significantly more difficult to understand, because they are obscured by a much bigger diff than is needed. Would you be willing to isolate the functional changes and resubmit? If you're not comfortable rewriting git history and force-pushing to GitHub, you might need to create a new branch. |
Author
|
@kurtmckee, you are correct - apologies didn't catch that! I will resubmit |
added 8 commits
October 27, 2022 02:08
This reverts commit 3b97df1.
This reverts commit 955e294.
…or/sqlalchemy-utils into default-db-override
Author
|
@kurtmckee, all sorted - diff looks much easier to read! |
Author
|
Hi, is this repo still actively maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Digital Ocean managed postgres database servers use 'defaultdb' instead of postgres.
This should be allowed to be changed, rather than hard coded