Conversation
…ance Agent-Logs-Url: https://github.com/kunitoki/LuaBridge3/sessions/35478d43-613d-42fb-8556-4fffe1634e91 Co-authored-by: kunitoki <707032+kunitoki@users.noreply.github.com>
Agent-Logs-Url: https://github.com/kunitoki/LuaBridge3/sessions/35478d43-613d-42fb-8556-4fffe1634e91 Co-authored-by: kunitoki <707032+kunitoki@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Allow NaN and Inf values in Stack<float> for error handling
Allow NaN and Inf to pass through Stack floating-point push/get/isInstance
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_floating_point_representable_by()rejected NaN and Inf withFloatingPointDoesntFitIntoLuaNumber— NaN due to IEEE 754 comparisons always returning false, Inf due to exceedingnumeric_limits::max(). Since Lua natively supports both, these values should pass through rather than error.Changes
Source/LuaBridge/detail/LuaHelpers.h/Distribution/LuaBridge/LuaBridge.h: Added early-returntrueforstd::isnan/std::isinfinis_floating_point_representable_by(). Droppedconstexpr(not valid for these calls in C++17) and added#include <cmath>.Tests/Source/StackTests.cpp: AddedFloatNaNAndInfPush,DoubleNaNAndInfPush,LongDoubleNaNAndInfPushcovering push,isInstance, and get round-trip for quiet NaN, +Inf, and −Inf.The fix is applied uniformly via
is_floating_point_representable_by(), sopush,get, andisInstanceall benefit forfloat,double, andlong double.⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.