Skip to content

config/jobs: update go to 1.25 in custom-metrics-apiserver #36157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
RainbowMango wants to merge 1 commit into
base: master
Choose a base branch
from
Open

config/jobs: update go to 1.25 in custom-metrics-apiserver #36157

RainbowMango wants to merge 1 commit into from

Conversation

@RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Jan 6, 2026

@RainbowMango
config/jobs: update go to 1.25 in custom-metrics-apiserver
0aa0e5e 
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Copilot AI review requested due to automatic review settings January 6, 2026 09:25
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RainbowMango
Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Jan 6, 2026
@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 6, 2026
Copilot AI reviewed Jan 6, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go version from 1.24 to 1.25 for all custom-metrics-apiserver presubmit jobs, as required by an upstream pull request.

  • Updates Docker container images from golang:1.24 to golang:1.25

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RainbowMango RainbowMango mentioned this pull request Jan 6, 2026
Open
@RainbowMango
Copy link
Member Author

RainbowMango commented Jan 6, 2026

@dgrisonnet Can you help review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@dims dims Awaiting requested review from dims

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

Assignees

No one assigned

Labels

area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RainbowMango @k8s-ci-robot