config: include --cri-timeout in containerd health-checker defaults#1307
config: include --cri-timeout in containerd health-checker defaults#1307dpacgdm wants to merge 1 commit into
Conversation
The health-checker binary honors --cri-timeout when passed via custom plugin rule args. The default containerd configs omitted the flag, so crictl used the 2s built-in default. Document the flag in the sample configs and add a unit test that --cri-timeout parses correctly. Signed-off-by: dpacgdm <dpac.gdm@gmail.com>
|
Hi @dpacgdm. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dpacgdm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary
--cri-timeoutis already supported by the health-checker binary and is correctly passed through custom plugin ruleargs. The default containerd health-checker configs omitted the flag, socrictlfell back to the 2s built-in default.This change:
--cri-timeout=10sto the Linux and Windows containerd sample configs--cri-timeoutparses correctlyRelated issue
#1248
Note: when the flag is present in rule
args, NPD already propagates it (util.Exec(ctx, rule.Path, rule.Args...)). The reporter's--timeout=2sobservation matches the default when the flag is absent from the config they deployed.Test plan
go test ./cmd/healthchecker/options -count=1