healthchecker: use kube-proxy /livez to avoid scale-down false alerts#1306
healthchecker: use kube-proxy /livez to avoid scale-down false alerts#1306dpacgdm wants to merge 1 commit into
Conversation
Cluster Autoscaler marks nodes with ToBeDeletedByClusterAutoscaler during scale-down. kube-proxy /healthz intentionally fails in that case for LB connection draining (KEP-3836), which made NPD report kube-proxy as unhealthy. Switch the kube-proxy probe to /livez, which reflects process health only. Signed-off-by: dpacgdm <dpac.gdm@gmail.com>
|
Hi @dpacgdm. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dpacgdm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary
Cluster Autoscaler marks nodes with
ToBeDeletedByClusterAutoscalerduring scale-down. kube-proxy/healthzintentionally fails in that case for load-balancer connection draining (KEP-3836), which caused NPD to report kube-proxy as unhealthy and fire unnecessary alerts.Switch the kube-proxy health check endpoint from
/healthzto/livez, which only reflects process health and stays healthy during expected scale-down.Related issue
#1176
Test plan
go test ./pkg/healthchecker/... ./cmd/healthchecker/.../livezfor kube-proxyMade with Cursor