Skip to content

Conversation

@self-sasi
Copy link
Contributor

@self-sasi self-sasi commented Jan 9, 2026

Summary

Replaces usage of the deprecated pflag ParseErrorsWhitelist field with ParseErrorsAllowlist to silence deprecation warnings and future-proof code.

Details

  • No functional behavior change
  • Addresses pflag deprecation warning
  • Aligns with current pflag API

Related issue

Fixes #22419

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 9, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: self-sasi / name: Sarthak Singh (5f704ec)

@k8s-ci-robot
Copy link
Contributor

Welcome @self-sasi!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @self-sasi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 9, 2026
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 9, 2026
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2026
@self-sasi
Copy link
Contributor Author

/assign @ComradeProgrammer @nirs

@medyagh
Copy link
Member

medyagh commented Jan 9, 2026

/lgtm thanks @self-sasi

@medyagh medyagh merged commit cc6c374 into kubernetes:master Jan 9, 2026
25 of 28 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, self-sasi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace deprecated pflag ParseErrorsWhitelist with ParseErrorsAllowlist

6 participants