-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix/etcd flaky test #22407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix/etcd flaky test #22407
Conversation
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aka1976mb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @aka1976mb. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
30da399 to
d668fc9
Compare
The 'validateOlmAddon' integration test was using a custom retry loop with 'retry.Expo' to check if the etcd operator's CSV had been successfully installed. This could lead to intermittent failures (flakes) in CI. This change replaces the custom Go retry loop with a single, more idiomatic 'kubectl wait' command. The command waits for the CSV's status phase to become 'Succeeded', using 'kubectl''s built-in polling mechanism. This makes the test more robust and less prone to flakiness.
d668fc9 to
54b4026
Compare
The 'validateOlmAddon' integration test was using a custom retry loop
with 'retry.Expo' to check if the etcd operator's CSV had been
successfully installed. This could lead to intermittent failures (flakes)
in CI.
This change replaces the custom Go retry loop with a single, more
idiomatic 'kubectl wait' command. The command waits for the CSV's
status phase to become 'Succeeded', using 'kubectl''s built-in polling
mechanism.
This makes the test more robust and less prone to flakiness.
Fixes #22408