Skip to content

Conversation

@aka1976mb
Copy link

@aka1976mb aka1976mb commented Jan 8, 2026

The 'validateOlmAddon' integration test was using a custom retry loop
with 'retry.Expo' to check if the etcd operator's CSV had been
successfully installed. This could lead to intermittent failures (flakes)
in CI.

This change replaces the custom Go retry loop with a single, more
idiomatic 'kubectl wait' command. The command waits for the CSV's
status phase to become 'Succeeded', using 'kubectl''s built-in polling
mechanism.

This makes the test more robust and less prone to flakiness.


Fixes #22408

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 8, 2026
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 8, 2026

CLA Missing ID

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 8, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aka1976mb
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @aka1976mb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@aka1976mb aka1976mb force-pushed the fix/etcd-flaky-test branch from 30da399 to d668fc9 Compare January 8, 2026 23:29
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2026
The 'validateOlmAddon' integration test was using a custom retry loop with 'retry.Expo' to check if the etcd operator's CSV had been successfully installed. This could lead to intermittent failures (flakes) in CI.

This change replaces the custom Go retry loop with a single, more idiomatic 'kubectl wait' command. The command waits for the CSV's status phase to become 'Succeeded', using 'kubectl''s built-in polling mechanism.

This makes the test more robust and less prone to flakiness.
@aka1976mb aka1976mb force-pushed the fix/etcd-flaky-test branch from d668fc9 to 54b4026 Compare January 9, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(integration): Flaky test in OLM addon for etcd readiness

3 participants