Skip to content

Conversation

@Wilson-Duncan
Copy link
Contributor

@Wilson-Duncan Wilson-Duncan commented Jan 7, 2026

Updated long description strings for regular and configuration based commands:

  • Fixed typos, spacing, and wording where needed
  • Added links to respective doc page

…nt and meeting sign up:

- Newlines between param link definitions for readability
- Added toml table for calendar rsvp button related variables
- Created partial for rsvp
- CSS styling for new partial
- Fixed typos, spacing, and wording where needed
- Added links to respective doc page
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2026
@k8s-ci-robot k8s-ci-robot requested review from nirs and prezha January 7, 2026 19:05
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Wilson-Duncan
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @Wilson-Duncan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

{{ template "community-links-list" . }}
{{ end }}

{{ partial "rsvp_button.html" . }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove unrelated changes to this PR

@@ -0,0 +1,11 @@
{{ $rsvp := .Site.Params.rsvp }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also not related to this PR

margin: 2rem 0;
}

.module-button:hover {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this Pr

site/config.toml Outdated
desc = "Kanban visualization of the next milestone"

# calendar rsvp
[params.rsvp]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz remove unrelated changes

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding the links to the long form, it looks good
but I noticed you have changes from the other PR please make sure when you make the PR to base it from master branch (instead of basing it off the unmerged branched)

- Fixed typos, spacing, and wording where needed

- Added links to respective doc page
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2026
@Wilson-Duncan Wilson-Duncan marked this pull request as ready for review January 8, 2026 03:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2026
{{ end }}
</ul>
{{ end }}
{{ end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all the unrelated extra lines added here.

.module-button:hover {
background: #164cb2;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

name = "keywords"
weight = 50
includeNewer = true
includeNewer = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same heree

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all the unrelated extra lines added here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants