-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update all minikube command descriptions with links to documentation #22396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update all minikube command descriptions with links to documentation #22396
Conversation
…nt and meeting sign up: - Newlines between param link definitions for readability - Added toml table for calendar rsvp button related variables - Created partial for rsvp - CSS styling for new partial
- Fixed typos, spacing, and wording where needed - Added links to respective doc page
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Wilson-Duncan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Wilson-Duncan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
| {{ template "community-links-list" . }} | ||
| {{ end }} | ||
|
|
||
| {{ partial "rsvp_button.html" . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove unrelated changes to this PR
| @@ -0,0 +1,11 @@ | |||
| {{ $rsvp := .Site.Params.rsvp }} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also not related to this PR
| margin: 2rem 0; | ||
| } | ||
|
|
||
| .module-button:hover { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to this Pr
site/config.toml
Outdated
| desc = "Kanban visualization of the next milestone" | ||
|
|
||
| # calendar rsvp | ||
| [params.rsvp] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz remove unrelated changes
medyagh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for adding the links to the long form, it looks good
but I noticed you have changes from the other PR please make sure when you make the PR to base it from master branch (instead of basing it off the unmerged branched)
- Fixed typos, spacing, and wording where needed - Added links to respective doc page
| {{ end }} | ||
| </ul> | ||
| {{ end }} | ||
| {{ end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove all the unrelated extra lines added here.
| .module-button:hover { | ||
| background: #164cb2; | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
| name = "keywords" | ||
| weight = 50 | ||
| includeNewer = true | ||
| includeNewer = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same heree
medyagh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove all the unrelated extra lines added here.
Updated long description strings for regular and configuration based commands: