Fix misleading Docker Desktop references in error messages#22312
Fix misleading Docker Desktop references in error messages#22312syscl wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: syscl The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Welcome @syscl! |
|
Hi @syscl. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
|
Hi @medyagh wish all is well! Apology for the late reply due to super busy recently, will put. Basically it is the log for the memory that is not accurate if I do not use Docker Desktop. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The problem is I didn't have docker desktop installed on my macOS, but it shows this confused information. The problem is the function assume people use docker desktop on macOS / Windows unconditionally, which is inaccurate and confused for debugging. This improves this logic handling.
The fix detects actual Docker runtime instead of assuming
Docker Desktop on macOS/Windows. Updates
IsDockerDesktop()to query daemoninfo and
FullName()to return the actual runtime name for accurate errormessages.