Skip to content

Conditions changes for batchAttach CR #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajguptavm wants to merge 2 commits into
base: master
Choose a base branch
from
+18 −8
Open

Conditions changes for batchAttach CR #3853

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b75edab
Conditions changes for batchAttach CR
rajguptavm Jan 8, 2026
a29aefb
type check for volume conditions
rajguptavm Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions tests/e2e/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2773,9 +2773,13 @@ func verifyIsAttachedInSupervisor(ctx context.Context, f *framework.Framework,
gomega.Expect(instance).NotTo(gomega.BeNil())
for _, vol := range instance.Status.VolumeStatus {
if vol.Name == volumeHandle {
// Access the Attached field within the PVC status
volumeAttachmentStatus = vol.PersistentVolumeClaim.Attached
break
for _, cond := range vol.PersistentVolumeClaim.Conditions {
// Access the Status & Type field within the PVC's Conditions
if string(cond.Type) == "VolumeAttached" && cond.Status == metav1.ConditionTrue {
volumeAttachmentStatus = true
break
}
}
}
}
framework.Logf("instance attached found to be : %t\n", volumeAttachmentStatus)
Expand All @@ -2800,11 +2804,17 @@ func verifyIsDetachedInSupervisor(ctx context.Context, f *framework.Framework,
if isBatchAttachSupported {
instance := getCnsNodeVMBatchAttachmentByName(ctx, f, nodeName, crdVersion, crdGroup)
gomega.Expect(instance).NotTo(gomega.BeNil())
for _, vol := range instance.Status.VolumeStatus {
if vol.Name == volumeHandle {
// Access the Attached field within the PVC status
volumeAttachmentStatus = vol.PersistentVolumeClaim.Attached
break
if instance.Status.VolumeStatus != nil {
for _, vol := range instance.Status.VolumeStatus {
if vol.Name == volumeHandle {
for _, cond := range vol.PersistentVolumeClaim.Conditions {
// Access the Status & Type field within the PVC's Conditions
if string(cond.Type) != "VolumeAttached" && cond.Status != metav1.ConditionTrue {
volumeAttachmentStatus = false
break
}
}
}
}
}
framework.Logf("instance attached found to be : %t\n", volumeAttachmentStatus)
Expand Down