Feat - Make target to build/push coverage enabled images #3832
+406
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolluria The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
kolluria
force-pushed
the
make-cover
branch
2 times, most recently
from
234af7c to
9fcdad5
Compare
k8s-ci-robot
added
size/L
kolluria
changed the title
kolluria
force-pushed
the
make-cover
branch
2 times, most recently
from
23e103c to
0ea0e99
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
kolluria
changed the title
- Add hack/cover-images.sh with prerequisite validation - Add Dockerfiles for coverage images (driver & syncer) - Add Makefile targets: cover-images, push-cover-images - Support custom registry with proper naming conventions
Contributor
Author
|
/cc @divyenpatel @xing-yang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces:
make cover-images- Build coverage images locallymake push-cover-images- Build and push to registry with custom registry supportThe implementation builds coverage binaries locally (leveraging Go cache) and then copies them into minimal Docker images.
Usage:
Which issue this PR fixes: fixes # N/A
Testing done:
Special notes for your reviewer:
N/A
Release note: