Fix listview task channel handling when task is replaced #3827
+1,004
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Collaborator
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
divyenpatel
force-pushed
the
address-listview-fixes-feedback
branch
from
4596a86 to
fe167ac
Compare
Collaborator
|
FAILED --- Jenkins Build #786 |
divyenpatel
force-pushed
the
address-listview-fixes-feedback
branch
from
fe167ac to
76b3b68
Compare
When Upsert is called with a new TaskDetails for an existing task (e.g., due to retry logic), the old channel was orphaned. The caller blocked on waitForResultOrTimeout would never receive a response. Changes: - Modified Upsert to return (TaskDetails, bool) so caller can detect when a task was replaced and send an error to the old channel - AddTask now sends error to old channel when replacing a task to unblock waiters - Added thread-safe locking to Count() method - Added comprehensive unit tests for TaskMap and listview functions The race condition between processTaskUpdate and reportErrorOnAllPendingTasks is handled correctly by existing non-blocking sends with buffer size 1.
divyenpatel
force-pushed
the
address-listview-fixes-feedback
branch
from
76b3b68 to
059fb57
Compare
k8s-ci-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When Upsert is called with a new TaskDetails for an existing task (e.g., due to retry logic), the old channel was orphaned. The caller blocked on waitForResultOrTimeout would never receive a response.
Changes:
The race condition between processTaskUpdate and reportErrorOnAllPendingTasks is handled correctly by existing non-blocking sends with buffer size 1.
Testing done:
Executed unit tests.
Pre-checkin
Special notes for your reviewer:
Release note: