Remove CNS PVC protection finalizer in cnsnodevmattachment reconciler when the CR itself is not found#3805
Closed
chethanv28 wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chethanv28 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We hit an issue with Supervisor PVC not getting deleted after namespace deletion due to cns pvc protection finalizer present on the PVC. The finalizer is not getting removed from the cnsnodevmattachment_controller's reconciler method. And the finalizer removal is missed due to cnsnodevmattachment CR itself getting deleted. This issue is not occurring consistently, however the PVC in Supervisor never gets deleted. For such cases, we need to remove the PVC finalizer before returning a success from reconcile method.
Testing done:
TBA
Special notes for your reviewer:
Release note: