handle CnsNotRegisteredFault, re-register volume and continue volume operations #3788
+679
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
divyenpatel
force-pushed
the
handle-CnsNotRegisteredFault
branch
4 times, most recently
from
bd3e2f8 to
8469478
Compare
divyenpatel
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
divyenpatel
force-pushed
the
handle-CnsNotRegisteredFault
branch
from
8469478 to
49fc6ee
Compare
k8s-ci-robot
added
size/XL
divyenpatel
force-pushed
the
handle-CnsNotRegisteredFault
branch
from
49fc6ee to
a2961cf
Compare
k8s-ci-robot
added
size/L
divyenpatel
force-pushed
the
handle-CnsNotRegisteredFault
branch
from
a2961cf to
2206fdb
Compare
k8s-ci-robot
added
size/XL
divyenpatel
force-pushed
the
handle-CnsNotRegisteredFault
branch
from
2206fdb to
7372aba
Compare
k8s-ci-robot
added
size/L
divyenpatel
force-pushed
the
handle-CnsNotRegisteredFault
branch
2 times, most recently
from
28411f8 to
cc3ea00
Compare
Collaborator
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
Collaborator
|
FAILED --- Jenkins Build #774 |
skogta
reviewed
Dec 19, 2025
skogta
reviewed
Dec 19, 2025
skogta
approved these changes
Dec 19, 2025
Contributor
skogta
left a comment
skogta
left a comment
There was a problem hiding this comment.
Have some minor comments. Overall looks good to me.
Collaborator
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
divyenpatel
force-pushed
the
handle-CnsNotRegisteredFault
branch
from
cc3ea00 to
394b218
Compare
k8s-ci-robot
added
size/XL
divyenpatel
force-pushed
the
handle-CnsNotRegisteredFault
branch
2 times, most recently
from
926700c to
90264e2
Compare
Collaborator
|
FAILED --- Jenkins Build #785 |
Collaborator
|
FAILED --- Jenkins Build #309 |
Collaborator
|
FAILED --- Jenkins Build #795 |
Collaborator
|
FAILED --- Jenkins Build #735 |
Collaborator
|
Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
Collaborator
|
Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
Collaborator
|
FAILED --- Jenkins Build #746 |
Collaborator
|
FAILED --- Jenkins Build #747 |
Collaborator
|
Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
Collaborator
|
Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
Collaborator
|
FAILED --- Jenkins Build #753 |
deepakkinni
reviewed
Jan 8, 2026
This commit adds handling for CnsNotRegisteredFault in various CNS volume operations for the WORKLOAD cluster flavor. When a volume operation fails with CnsNotRegisteredFault, the driver now attempts to re-register the volume with CNS and retries the operation. Changes include: - Add clusterId and clusterDistribution parameters to GetManager() for volume re-registration - Add ReRegisterVolume() public method to re-register unregistered volumes - Add IsCnsNotRegisteredFault() helper to detect the fault type - Add IsCnsVolumeAlreadyExistsFault() helper for idempotent re-registration - Handle CnsNotRegisteredFault in: - AttachVolume - DetachVolume - DeleteVolume (with improved idempotency) - UpdateVolumeMetadata - UpdateVolumeCrypto - ExpandVolume (with improved idempotency) - CreateSnapshot (with improved idempotency and with transaction) - DeleteSnapshot - RelocateVolume (in migrationController) The re-registration is only attempted once per operation to prevent infinite loops. If re-registration fails or the retry fails, the original error is returned.
divyenpatel
force-pushed
the
handle-CnsNotRegisteredFault
branch
from
90264e2 to
7a6be88
Compare
Collaborator
|
Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete |
Collaborator
|
/approve |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepakkinni, divyenpatel, skogta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit adds handling for CnsNotRegisteredFault in various CNS volume
operations for the WORKLOAD cluster flavor. When a volume operation fails
with CnsNotRegisteredFault, the driver now attempts to re-register the
volume with CNS and retries the operation.
Changes include:
volume re-registration
The re-registration is only attempted once per operation to prevent
infinite loops. If re-registration fails or the retry fails, the
original error is returned.
Testing done:
Refer to tests and logs here - https://gist.github.com/divyenpatel/c48fddcc2bb7323fbbd168d4e035ff6a
pre-checkin runs:
Special notes for your reviewer:
Release note: