-
Notifications
You must be signed in to change notification settings - Fork 501
Bump kubeadm.k8s.io to v1beta4. #8500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tenzen-y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
Could you address
Line 114 in b7fdcd4
| apiVersion: kubeadm.k8s.io/v1beta3 |
adf65e1 to
26be6f4
Compare
tenzen-y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🥇
/lgtm
/approve
|
LGTM label has been added. DetailsGit tree hash: f230546fb5fc89cdc230beffb672886cca438c11 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@mbobrovskyi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
neolit123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubeadm maintainer here.
note that the extraArgs format changed in v1beta4, so the change in this PR is incomplete.
you can read the v1beta4 doc.go for more info.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump kubeadm.k8s.io to v1beta4.
Which issue(s) this PR fixes:
Fixes #8498
Special notes for your reviewer:
Does this PR introduce a user-facing change?