Use timeout as fallback when recoveryTimeout is not specified#8493
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Jan 19, 2026
Merged
Conversation
k8s-ci-robot
added
release-note
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
IrvingMg
force-pushed
the
feature/wait-for-pods-ready-timeout-fallback
branch
from
0563d44 to
7d56d0c
Compare
Member
Author
|
I’ve updated the PR to allow disabling |
pajakd
reviewed
Jan 19, 2026
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: bf0c618e705ecdad45b070808e16f1ff7b29216a |
IrvingMg
force-pushed
the
feature/wait-for-pods-ready-timeout-fallback
branch
from
7d56d0c to
508d46e
Compare
k8s-ci-robot
removed
the
lgtm
tenzen-y
reviewed
Jan 19, 2026
IrvingMg
force-pushed
the
feature/wait-for-pods-ready-timeout-fallback
branch
from
508d46e to
4dfe799
Compare
IrvingMg
force-pushed
the
feature/wait-for-pods-ready-timeout-fallback
branch
from
4dfe799 to
0d4de84
Compare
tenzen-y
reviewed
Jan 19, 2026
Member
tenzen-y
left a comment
tenzen-y
left a comment
There was a problem hiding this comment.
Awesome, thank you!
/lgtm
/approve
Assuming CI passes
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: e14cbebda4d3c1677727a7a676772199401fa9f7 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IrvingMg, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
thejoeejoee
pushed a commit
to thejoeejoee/kueue
that referenced
this pull request
Jan 20, 2026
yashnib
pushed a commit
to yashnib/kueue
that referenced
this pull request
Jan 22, 2026
dongjiang1989
pushed a commit
to dongjiang1989/kueue
that referenced
this pull request
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Makes
waitForPodsReady.timeoutthe fallback value whenwaitForPodsReady.recoveryTimeoutis not specified.Which issue(s) this PR fixes:
Fixes #8300
Special notes for your reviewer:
Does this PR introduce a user-facing change?