Stabilize multikueue integration tests by increasing shared timeouts#8470
Stabilize multikueue integration tests by increasing shared timeouts#8470skools-here wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @skools-here. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
64dc584 to
6e66858
Compare
|
I am working on fixing the changes and fails. |
6e66858 to
0188172
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: skools-here The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| TinyTimeout = 10 * time.Millisecond | ||
| ShortTimeout = time.Second | ||
| Timeout = 10 * time.Second | ||
| Timeout = 2 * time.Second |
There was a problem hiding this comment.
I don’t understand why you decreased the timeout. If you need a longer timeout for a specific test, please adjust it there, but don’t change these constants.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skools-here: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/kind flake
/kind failing-test
What this PR does / why we need it:
The multikueue integration test suite has been flaky in CI due to aggressive
shared timeouts. In slower CI environments, controller startup and
cross-cluster reconciliation can legitimately take longer than the current
limits, causing intermittent test failures.
This PR increases the shared test timeouts used by integration tests to make
the multikueue test suite deterministic and stable in CI.
Which issue(s) this PR fixes:
Fixes #8463
Special notes for your reviewer:
of multikueue integration tests.
Does this PR introduce a user-facing change?