Skip to content

Stabilize multikueue integration tests by increasing shared timeouts#8470

Open
skools-here wants to merge 1 commit intokubernetes-sigs:mainfrom
skools-here:fix/multikueue-flake-test
Open

Stabilize multikueue integration tests by increasing shared timeouts#8470
skools-here wants to merge 1 commit intokubernetes-sigs:mainfrom
skools-here:fix/multikueue-flake-test

Conversation

@skools-here
Copy link
Copy Markdown
Contributor

/kind flake
/kind failing-test

What this PR does / why we need it:

The multikueue integration test suite has been flaky in CI due to aggressive
shared timeouts. In slower CI environments, controller startup and
cross-cluster reconciliation can legitimately take longer than the current
limits, causing intermittent test failures.

This PR increases the shared test timeouts used by integration tests to make
the multikueue test suite deterministic and stable in CI.

Which issue(s) this PR fixes:

Fixes #8463

Special notes for your reviewer:

  • This change only affects test utilities.
  • No production logic or behavior is modified.
  • The timeout increase aligns with the asynchronous and multi-cluster nature
    of multikueue integration tests.
  • CI environments are expected to be slower than local setups.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jan 8, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 8, 2026

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 0188172
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6960917142eb6100082e573b
😎 Deploy Preview https://deploy-preview-8470--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @skools-here. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2026
@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented Jan 8, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2026
@skools-here skools-here force-pushed the fix/multikueue-flake-test branch from 64dc584 to 6e66858 Compare January 8, 2026 14:48
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2026
@skools-here
Copy link
Copy Markdown
Contributor Author

I am working on fixing the changes and fails.

@skools-here skools-here force-pushed the fix/multikueue-flake-test branch from 6e66858 to 0188172 Compare January 9, 2026 05:26
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skools-here
Once this PR has been reviewed and has the lgtm label, please assign pbundyra for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2026
Comment thread test/util/constants.go
TinyTimeout = 10 * time.Millisecond
ShortTimeout = time.Second
Timeout = 10 * time.Second
Timeout = 2 * time.Second
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t understand why you decreased the timeout. If you need a longer timeout for a specific test, please adjust it there, but don’t change these constants.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@skools-here: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-integration-extended-main 0188172 link true /test pull-kueue-test-integration-extended-main
pull-kueue-test-integration-multikueue-main 0188172 link true /test pull-kueue-test-integration-multikueue-main
pull-kueue-test-integration-baseline-main 0188172 link true /test pull-kueue-test-integration-baseline-main
pull-kueue-test-e2e-multikueue-main 0188172 link true /test pull-kueue-test-e2e-multikueue-main
pull-kueue-test-e2e-customconfigs-main 0188172 link true /test pull-kueue-test-e2e-customconfigs-main
pull-kueue-test-e2e-main-1-33 0188172 link true /test pull-kueue-test-e2e-main-1-33
pull-kueue-test-e2e-main-1-32 0188172 link true /test pull-kueue-test-e2e-main-1-32
pull-kueue-test-e2e-main-1-34 0188172 link true /test pull-kueue-test-e2e-main-1-34
pull-kueue-test-e2e-tas-main 0188172 link true /test pull-kueue-test-e2e-tas-main
pull-kueue-test-e2e-dra-main 0188172 link true /test pull-kueue-test-e2e-dra-main
pull-kueue-test-e2e-main-1-35 0188172 link true /test pull-kueue-test-e2e-main-1-35
pull-kueue-test-e2e-multikueue-dra-main 0188172 link true /test pull-kueue-test-e2e-multikueue-dra-main
pull-kueue-test-e2e-multikueue-sequential-main 0188172 link true /test pull-kueue-test-e2e-multikueue-sequential-main
pull-kueue-test-e2e-sequential-baseline-main 0188172 link true /test pull-kueue-test-e2e-sequential-baseline-main
pull-kueue-test-e2e-sequential-extended-main 0188172 link true /test pull-kueue-test-e2e-sequential-extended-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integration multikueue tests suite is flaking

4 participants