Skip to content

[WIP] Prefer higher priority workloads over sticky workload as a head in a cluster queue#8450

Closed
j-skiba wants to merge 5 commits intokubernetes-sigs:mainfrom
j-skiba:fix-higher-priority-wl-blocked-by-sticky-wl
Closed

[WIP] Prefer higher priority workloads over sticky workload as a head in a cluster queue#8450
j-skiba wants to merge 5 commits intokubernetes-sigs:mainfrom
j-skiba:fix-higher-priority-wl-blocked-by-sticky-wl

Conversation

@j-skiba
Copy link
Copy Markdown
Contributor

@j-skiba j-skiba commented Jan 7, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes:

  • decreases number of performed preemptions when higher priority workload is admitted and sticky workload is lower priority

Which issue(s) this PR fixes:

Fixes #7301

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed a priority inversion issue where higher-priority workloads could be blocked by a "sticky" lower-priority workload that had already initiated preemption.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jan 7, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 7, 2026

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 1c4be4f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6960e5b9e2a0c7000818cee4
😎 Deploy Preview https://deploy-preview-8450--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: j-skiba
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from mimowo and pajakd January 7, 2026 14:28
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 7, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @j-skiba. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 7, 2026
@mbobrovskyi
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2026
@j-skiba j-skiba changed the title Prefer higher priority workloads over sticky workload as a head in a cluster queue [WIP] Prefer higher priority workloads over sticky workload as a head in a cluster queue Jan 8, 2026
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2026
@j-skiba j-skiba force-pushed the fix-higher-priority-wl-blocked-by-sticky-wl branch from 0d54412 to 1c4be4f Compare January 9, 2026 11:25
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2026
@j-skiba
Copy link
Copy Markdown
Contributor Author

j-skiba commented Jan 9, 2026

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@j-skiba: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-unit-main 1c4be4f link true /test pull-kueue-test-unit-main
pull-kueue-test-integration-baseline-main 1c4be4f link true /test pull-kueue-test-integration-baseline-main
pull-kueue-test-e2e-main-1-35 1c4be4f link true /test pull-kueue-test-e2e-main-1-35

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@j-skiba j-skiba closed this Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Higher-priority workloads are blocked while a “sticky” low-priority workload is pinned to the head of the queue

3 participants