Add e2e tests clusterprofile with plugin #8318
Add e2e tests clusterprofile with plugin #8318k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
cc @kshalot |
2c15198 to
b4ff3a5
Compare
|
/ok-to-test |
b4ff3a5 to
1a1cd2f
Compare
|
/test pull-kueue-verify-main |
1a1cd2f to
693d967
Compare
|
/test pull-kueue-verify-main |
693d967 to
e62cd89
Compare
e62cd89 to
0ccbb56
Compare
| } | ||
|
|
||
| func GetClusterProfilePluginImage() string { | ||
| clusterProfilePluginImage, found := os.LookupEnv("CLUSTERPROFILE_PLUGIN_IMAGE") |
There was a problem hiding this comment.
Can we set default value?
There was a problem hiding this comment.
We don'y have default value for Ray and I thought maybe there is no need, you probably think about running tests locally, right?
There was a problem hiding this comment.
Yeah, it would be easier to run tests with default value.
There was a problem hiding this comment.
But yeah, I think you right, we can't calculate it for default value.
39b21b9 to
80afefc
Compare
80afefc to
e59b7fe
Compare
|
Let me merge as is, we can follow up with #8318 (comment) if something is left there (but this is unclear to me atm) |
|
LGTM label has been added. DetailsGit tree hash: 740b526d43d50211d38cdfb4c6876d72a5a3b540 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kshalot, mimowo, mszadkow The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-0.15 |
|
@mimowo: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mimowo: #8318 failed to apply on top of branch "release-0.15": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mszadkow could you please try to cherrypick this one? I expect we will need to cherrypick some fixes to 0.15 in the future, so it would be handy to have the e2e tests on the release branch. Let me know if this is not feasible. |
|
/kind feature |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add new MultiKueue e2e test for ClusterProfile feature with use of
secretreaderplugin.Which issue(s) this PR fixes:
Fixes #7943
Special notes for your reviewer:
Does this PR introduce a user-facing change?