Skip to content

Add e2e tests clusterprofile with plugin #8318

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
epam:feat/7943-e2e-clusterprofile-plugin-tests
Jan 16, 2026
Merged

Add e2e tests clusterprofile with plugin #8318
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
epam:feat/7943-e2e-clusterprofile-plugin-tests

Conversation

@mszadkow
Copy link
Copy Markdown
Contributor

@mszadkow mszadkow commented Dec 18, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add new MultiKueue e2e test for ClusterProfile feature with use of secretreader plugin.

Which issue(s) this PR fixes:

Fixes #7943

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 18, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 18, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit e59b7fe
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/696a100647f5db0008d90816

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 18, 2025
@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented Dec 18, 2025

cc @kshalot

@mszadkow mszadkow force-pushed the feat/7943-e2e-clusterprofile-plugin-tests branch from 2c15198 to b4ff3a5 Compare December 18, 2025 09:41
@mszadkow
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 18, 2025
Comment thread hack/multikueue/secretreader/Dockerfile
Comment thread test/e2e/multikueue/ginkgo.report Outdated
Comment thread hack/multikueue/secretreader/Dockerfile Outdated
@mszadkow mszadkow force-pushed the feat/7943-e2e-clusterprofile-plugin-tests branch from b4ff3a5 to 1a1cd2f Compare December 22, 2025 11:00
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 22, 2025
@mszadkow
Copy link
Copy Markdown
Contributor Author

/test pull-kueue-verify-main
/test pull-kueue-test-e2e-multikueue-main

@mszadkow mszadkow force-pushed the feat/7943-e2e-clusterprofile-plugin-tests branch from 1a1cd2f to 693d967 Compare December 22, 2025 14:35
@mszadkow
Copy link
Copy Markdown
Contributor Author

/test pull-kueue-verify-main
/test pull-kueue-test-e2e-multikueue-main

@mszadkow mszadkow force-pushed the feat/7943-e2e-clusterprofile-plugin-tests branch from 693d967 to e62cd89 Compare December 22, 2025 16:13
@mszadkow mszadkow changed the title [WIP] Feat/7943 e2e clusterprofile plugin tests Add e2e tests clusterprofile with plugin Dec 22, 2025
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 22, 2025
@mszadkow mszadkow marked this pull request as ready for review December 22, 2025 16:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2025
@mszadkow mszadkow force-pushed the feat/7943-e2e-clusterprofile-plugin-tests branch from e62cd89 to 0ccbb56 Compare December 22, 2025 16:19
Comment thread hack/multikueue/secretreader/Dockerfile Outdated
Comment thread hack/multikueue/secretreader/Dockerfile
Comment thread hack/multikueue/secretreader/Dockerfile Outdated
Comment thread test/e2e/multikueue/suite_test.go Outdated
Comment thread Makefile-test.mk
Comment thread test/util/util.go
Comment thread test/util/e2e.go
}

func GetClusterProfilePluginImage() string {
clusterProfilePluginImage, found := os.LookupEnv("CLUSTERPROFILE_PLUGIN_IMAGE")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set default value?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don'y have default value for Ray and I thought maybe there is no need, you probably think about running tests locally, right?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it would be easier to run tests with default value.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yeah, I think you right, we can't calculate it for default value.

@mszadkow mszadkow force-pushed the feat/7943-e2e-clusterprofile-plugin-tests branch from 39b21b9 to 80afefc Compare January 15, 2026 16:42
@mszadkow mszadkow force-pushed the feat/7943-e2e-clusterprofile-plugin-tests branch from 80afefc to e59b7fe Compare January 16, 2026 10:16
@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented Jan 16, 2026

Let me merge as is, we can follow up with #8318 (comment) if something is left there (but this is unclear to me atm)
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 740b526d43d50211d38cdfb4c6876d72a5a3b540

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kshalot, mimowo, mszadkow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2026
@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented Jan 16, 2026

/cherrypick release-0.15

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of release-0.15 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit bedf096 into kubernetes-sigs:main Jan 16, 2026
30 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.16 milestone Jan 16, 2026
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown
Contributor

@mimowo: #8318 failed to apply on top of branch "release-0.15":

Applying: Add full MultiKueue e2e tests for ClusterProfile with plugins
Using index info to reconstruct a base tree...
M	Makefile
M	Makefile-deps.mk
M	Makefile-test.mk
M	hack/e2e-common.sh
M	hack/internal/tools/go.mod
M	hack/internal/tools/go.sum
M	test/e2e/multikueue/e2e_test.go
M	test/e2e/singlecluster/visibility_test.go
M	test/util/e2e.go
Falling back to patching base and 3-way merge...
Auto-merging test/util/e2e.go
Auto-merging test/e2e/singlecluster/visibility_test.go
Auto-merging test/e2e/multikueue/e2e_test.go
Auto-merging hack/internal/tools/go.sum
CONFLICT (content): Merge conflict in hack/internal/tools/go.sum
Auto-merging hack/internal/tools/go.mod
CONFLICT (content): Merge conflict in hack/internal/tools/go.mod
Auto-merging hack/e2e-common.sh
Auto-merging Makefile-test.mk
Auto-merging Makefile-deps.mk
CONFLICT (content): Merge conflict in Makefile-deps.mk
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add full MultiKueue e2e tests for ClusterProfile with plugins

Details

In response to this:

/cherrypick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented Jan 16, 2026

@mszadkow could you please try to cherrypick this one? I expect we will need to cherrypick some fixes to 0.15 in the future, so it would be handy to have the e2e tests on the release branch. Let me know if this is not feasible.

@tenzen-y
Copy link
Copy Markdown
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MultiKueue via ClusterProfile: add full e2e tests to confirm using a plugin for kind

7 participants