Skip to content

Conversation

@sivaramsingana
Copy link
Contributor

@sivaramsingana sivaramsingana commented Jan 7, 2026

fix: Updated job name elastx-ubuntu20 to ubuntu 24

What type of PR is this?

/kind bug

What this PR does / why we need it:
This should update the job name to ubuntu24, and maybe we'll update the CI test coverage

Which issue(s) this PR fixes:
Fixes #12841

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 7, 2026
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 7, 2026

CLA Signed

@k8s-ci-robot
Copy link
Contributor

Welcome @sivaramsingana!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @sivaramsingana. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 7, 2026
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't delete our PR template, and following the template to fill in.

Signing your CLA, and read the issue content. (don't forgot to update the CI matrix)

@tico88612
Copy link
Member

BTW, you need to rename the test file.

Signed-off-by: sivaram <singana.sivaram.naidu@ibm.com>
@sivaramsingana sivaramsingana reopened this Jan 8, 2026
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 8, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@linux-foundation-easycla
Copy link

CLA Not Signed

@sivaramsingana
Copy link
Contributor Author

@tico88612 Please review changes and give lgtm.

@tico88612
Copy link
Member

@sivaramsingana please resolve your CLA first.

@sivaramsingana
Copy link
Contributor Author

@tico88612 FYI, Request for CLA authorization. Waiting for request to be approved.

@tico88612
Copy link
Member

@sivaramsingana #12844 (comment)
If you can't resolve it, we can't merge or test your code.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 9, 2026
@sivaramsingana
Copy link
Contributor Author

@tico88612 My CLA authorization is verified now

@tico88612
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2026
@tico88612
Copy link
Member

Could you help me delete this (tests/files/tf-ovh_ubuntu20-calico.yml)? We no longer use OVH in our CI.

@tico88612
Copy link
Member

tico88612 commented Jan 10, 2026

Edit your PR content, don't delete our release-note block.

```release-note
NONE
```

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 10, 2026
Signed-off-by: sivaram <singana.sivaram.naidu@ibm.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2026
@tico88612
Copy link
Member

@sivaramsingana could you check pre-commit error log?

Signed-off-by: sivaram <singana.sivaram.naidu@ibm.com>
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sivaramsingana, tico88612

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2026
@k8s-ci-robot k8s-ci-robot merged commit d41b629 into kubernetes-sigs:master Jan 10, 2026
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Elastx test name is not align with OS version

3 participants