-
Notifications
You must be signed in to change notification settings - Fork 6.8k
updated elastx_ubuntu20 to ubuntu24 #12844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated elastx_ubuntu20 to ubuntu24 #12844
Conversation
|
Welcome @sivaramsingana! |
|
Hi @sivaramsingana. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tico88612
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't delete our PR template, and following the template to fill in.
Signing your CLA, and read the issue content. (don't forgot to update the CI matrix)
|
BTW, you need to rename the test file. |
4dacf56 to
851abbc
Compare
Signed-off-by: sivaram <singana.sivaram.naidu@ibm.com>
|
|
@tico88612 Please review changes and give lgtm. |
|
@sivaramsingana please resolve your CLA first. |
|
@tico88612 FYI, Request for CLA authorization. Waiting for request to be approved. |
|
@sivaramsingana #12844 (comment) |
|
@tico88612 My CLA authorization is verified now |
|
/ok-to-test |
|
Could you help me delete this (tests/files/tf-ovh_ubuntu20-calico.yml)? We no longer use OVH in our CI. |
|
Edit your PR content, don't delete our release-note block. |
Signed-off-by: sivaram <singana.sivaram.naidu@ibm.com>
|
@sivaramsingana could you check |
Signed-off-by: sivaram <singana.sivaram.naidu@ibm.com>
tico88612
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sivaramsingana, tico88612 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix: Updated job name elastx-ubuntu20 to ubuntu 24
What type of PR is this?
/kind bug
What this PR does / why we need it:
This should update the job name to ubuntu24, and maybe we'll update the CI test coverage
Which issue(s) this PR fixes:
Fixes #12841
Does this PR introduce a user-facing change?: