vSphere updates#12781
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: luringens The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @luringens. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Relates to #12406 in that it updates the manifests, but does not add support for multiple vcenters and zoning. Marking as WIP as I haven't had a chance to test this yet, but I figured I'd put up the draft anyways. |
a9ae292 to
a5c1d84
Compare
|
Snapshotter v7 also notes that it needs to be reinstalled completely, so I need to look into how best to do that, or perhaps if it'll just have to be an action required changelog item. https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v7.0.0 edit: probably not relevant to a sidecar deployment |
|
/ok-to-test |
It was fully removed in 1.30
`vsphere_csi_snapshotter_image_tag` was missing from the list of variables.
Add some additional advice about picking component versions, as well as links to relevant documentation. It'll hopefully be useful for new users of this subsystem!
This raises all components to the ones supporting Kubernetes 1.34, and in the case of csi-provisioner raises the minimum supported Kubernetes version to 1.34. This is a breaking change for users on previous versions who need to pin the version to a previous version.
Aligns the manifests with upstream ones from: https://github.com/kubernetes/cloud-provider-vsphere/blob/master/releases/v1.34/vsphere-cloud-controller-manager.yaml
These should now align more closely with the latest changes from here: https://github.com/kubernetes-sigs/vsphere-csi-driver/tree/master/manifests/vanilla To simplify the configuration a bit, jinja templating to support vSphere 6.7 has been removed. That version is far past end-of-life.
Downgrades components again to match the supported versions listed in the driver documentation at https://techdocs.broadcom.com/us/en/vmware-cis/vsphere/container-storage-plugin/3-0/release-notes/vmware-vsphere-container-storage-plugin-30-release-notes.html
a5c1d84 to
9146dba
Compare
|
Deployed to our clusters and works well! 🙂 |
|
/label tide/merge-method-merge |
|
I don't recommend continuing to maintain the yaml config (in Kubespray, this is out of scope for us). Is it possible to implement it using a helm chart instead? |
|
It is probably possible, but I am no longer on our Kubernetes team and can't allocate more time to the project. I hope this at least helps keep the config already present in a good state and supporting recent Kubernetes releases, even if it should be replaced in the future. |
Oh, that's too bad. :(
It mainly comes down to whether the maintainers have the capacity to handle it; if we use Helm Charts, we don't have to worry about anything beyond the app itself. |
/kind feature
What this PR does / why we need it:
Update vSphere CSI and CPI components, documentation and manifests, as the current defaults versions do not support the current default Kubernetes version.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: