-
Notifications
You must be signed in to change notification settings - Fork 6.8k
cleanup: Deprecate Ingress-Nginx from kubernetes-apps #12767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jmeza-xyz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @jmeza-xyz. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Meza <meza-xyz@proton.me>
Signed-off-by: Meza <meza-xyz@proton.me>
|
/hold |
|
/kind deprecation |
|
/ok-to-test |
1379752 to
ddb5ff1
Compare
4846ed5 to
dfdeb35
Compare
|
Ran the # pre-commit run -a
check for added large files..........................................................Passed
check for case conflicts.............................................................Passed
check that executables have shebangs.................................................Passed
check xml............................................................................Passed
check for merge conflicts............................................................Passed
detect private key...................................................................Passed
fix end of files.....................................................................Passed
forbid new submodules............................................(no files to check)Skipped
fix requirements.txt.................................................................Passed
trim trailing whitespace.............................................................Passed
yamllint.............................................................................Passed
shellcheck...........................................................................Passed
ansible-lint.........................................................................Passed
misspell.............................................................................Passed
Build and install kubernetes-sigs.kubespray Ansible collection.......................Passed
generate-docs-sidebar................................................................Passed
ci-matrix............................................................................Passed
Verify correct version for galaxy.yml................................................Passed
jinja-syntax-check...................................................................Passed
Update static files referencing default kubespray values.............................Passed
Check that our checksums are correctly sorted by version.............................Passed
Markdownlint.........................................................................Passed |
|
@jmeza-xyz don't use merge commit, please use rebase |
dfdeb35 to
dbc9d88
Compare
dbc9d88 to
19e2397
Compare
Signed-off-by: Meza <meza-xyz@proton.me>
Signed-off-by: Meza <meza-xyz@proton.me>
Signed-off-by: Meza <meza-xyz@proton.me>
Signed-off-by: Meza <meza-xyz@proton.me>
Signed-off-by: Meza <meza-xyz@proton.me>
Signed-off-by: Meza <meza-xyz@proton.me>
19e2397 to
b1b3690
Compare
|
@tico88612 Reverted and used rebase to merge from the docs branch. Will wait for the CI to finish to fix any errors. Thanks |
|
/retest-failed |
|
/retest |
What type of PR is this?
What this PR does / why we need it:
This deprecates/removes ingress-nginx as part of the kube-apps ingress-controller due to project retirement.
Which issue(s) this PR fixes:
Fixes #12712
Special notes for your reviewer:
Need to confirm testing of removing ingress_nginx_enabled value in the registry task and that ingress_alb_enabled works.
Does this PR introduce a user-facing change?: