Skip to content

Conversation

@jmeza-xyz
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
This deprecates/removes ingress-nginx as part of the kube-apps ingress-controller due to project retirement.

Which issue(s) this PR fixes:

Fixes #12712

Special notes for your reviewer:

Need to confirm testing of removing ingress_nginx_enabled value in the registry task and that ingress_alb_enabled works.

Does this PR introduce a user-facing change?:

cleanup: remove ingress-nginx from kubernetes-apps ingress-controller

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmeza-xyz
Once this PR has been reviewed and has the lgtm label, please assign ant31 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @jmeza-xyz. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2025
@jmeza-xyz jmeza-xyz marked this pull request as draft December 5, 2025 23:34
@tico88612
Copy link
Member

/hold
until 2.30.0 release.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2025
@tico88612
Copy link
Member

/kind deprecation

@k8s-ci-robot k8s-ci-robot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Dec 6, 2025
@yankay
Copy link
Member

yankay commented Dec 8, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2025
@jmeza-xyz jmeza-xyz force-pushed the ingress-nginx-sunset branch from 1379752 to ddb5ff1 Compare December 19, 2025 02:32
@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 19, 2025
@jmeza-xyz jmeza-xyz force-pushed the ingress-nginx-sunset branch from 4846ed5 to dfdeb35 Compare December 19, 2025 02:34
@jmeza-xyz
Copy link
Contributor Author

Ran the pre-commit-run -a ; results below.

#  pre-commit run -a
check for added large files..........................................................Passed
check for case conflicts.............................................................Passed
check that executables have shebangs.................................................Passed
check xml............................................................................Passed
check for merge conflicts............................................................Passed
detect private key...................................................................Passed
fix end of files.....................................................................Passed
forbid new submodules............................................(no files to check)Skipped
fix requirements.txt.................................................................Passed
trim trailing whitespace.............................................................Passed
yamllint.............................................................................Passed
shellcheck...........................................................................Passed
ansible-lint.........................................................................Passed
misspell.............................................................................Passed
Build and install kubernetes-sigs.kubespray Ansible collection.......................Passed
generate-docs-sidebar................................................................Passed
ci-matrix............................................................................Passed
Verify correct version for galaxy.yml................................................Passed
jinja-syntax-check...................................................................Passed
Update static files referencing default kubespray values.............................Passed
Check that our checksums are correctly sorted by version.............................Passed
Markdownlint.........................................................................Passed

@tico88612
Copy link
Member

@jmeza-xyz don't use merge commit, please use rebase

Signed-off-by: Meza <meza-xyz@proton.me>
Signed-off-by: Meza <meza-xyz@proton.me>
Signed-off-by: Meza <meza-xyz@proton.me>
Signed-off-by: Meza <meza-xyz@proton.me>
Signed-off-by: Meza <meza-xyz@proton.me>
Signed-off-by: Meza <meza-xyz@proton.me>
@jmeza-xyz jmeza-xyz force-pushed the ingress-nginx-sunset branch from 19e2397 to b1b3690 Compare December 26, 2025 23:04
@jmeza-xyz jmeza-xyz marked this pull request as ready for review December 26, 2025 23:15
@jmeza-xyz
Copy link
Contributor Author

@tico88612 Reverted and used rebase to merge from the docs branch. Will wait for the CI to finish to fix any errors. Thanks

@tico88612
Copy link
Member

/retest-failed

@tico88612
Copy link
Member

/retest

@jmeza-xyz jmeza-xyz changed the title wip: cleanup: Deprecate Ingress-Nginx from kubernetes-apps cleanup: Deprecate Ingress-Nginx from kubernetes-apps Dec 31, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ingress NGINX sunset

4 participants