Skip to content

Conversation

@11qeq11
Copy link

@11qeq11 11qeq11 commented Dec 5, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

This is basically a follow-up to #9549 and #9563. When trying to remove node from cluster which has Flannel CNI, the job will fail with:

$ ansible-playbook -i inventory/kubespray-local-deployment/inventory.yml remove-node.yml -e node=kubespray-node-3 -b -v \
  --private-key=~/.ssh/id_ed25519
...
TASK [network_plugin/cni : CNI | Copy cni plugins] ****************************************************************************************
fatal: [kubespray-node-3]: FAILED! => {"changed": false, "msg": "Source '/tmp/releases/cni-plugins-linux-amd64-1.8.0.tgz' does not exist"}
...

Based on previous discussions, this dependency can be safely removed since it's not needed ever since https://github.com/kubernetes-sigs/kubespray/pull/9367/files.

Which issue(s) this PR fixes:

Haven't created one for Flannel.
Special notes for your reviewer:

Made this PR based on suggestions here.

Does this PR introduce a user-facing change?:

fix: remove cni dependency for flannel

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 5, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 5, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: 11qeq11 / name: Oleksandr Kozmenko (d20b24d)

@k8s-ci-robot
Copy link
Contributor

Welcome @11qeq11!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @11qeq11. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 5, 2025
@11qeq11 11qeq11 force-pushed the fix/remove-cni-denpendeny-for-flannel branch from 74e849f to d20b24d Compare December 5, 2025 18:17
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 5, 2025
@yankay
Copy link
Member

yankay commented Dec 8, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2025
@11qeq11
Copy link
Author

11qeq11 commented Dec 11, 2025

/retest

Copy link
Contributor

@cyclinder cyclinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 11qeq11, cyclinder
Once this PR has been reviewed and has the lgtm label, please assign tico88612 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@11qeq11
Copy link
Author

11qeq11 commented Dec 11, 2025

/assign @tico88612

@tico88612
Copy link
Member

@11qeq11 I'm more curious about under what circumstances removing a node would copy the CNI file.
If that's the case, then other CNI plugins should also be removed, not just flannel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants