-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix: remove cni dependency for flannel #12766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: remove cni dependency for flannel #12766
Conversation
|
|
|
Welcome @11qeq11! |
|
Hi @11qeq11. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
74e849f to
d20b24d
Compare
|
/ok-to-test |
|
/retest |
cyclinder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 11qeq11, cyclinder The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @tico88612 |
|
@11qeq11 I'm more curious about under what circumstances removing a node would copy the CNI file. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This is basically a follow-up to #9549 and #9563. When trying to remove node from cluster which has Flannel CNI, the job will fail with:
Based on previous discussions, this dependency can be safely removed since it's not needed ever since https://github.com/kubernetes-sigs/kubespray/pull/9367/files.
Which issue(s) this PR fixes:
Haven't created one for Flannel.
Special notes for your reviewer:
Made this PR based on suggestions here.
Does this PR introduce a user-facing change?: