refactor(bastion-ssh-config): Centralize bastion_port default value#12651
refactor(bastion-ssh-config): Centralize bastion_port default value#12651legitYosal wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
Move the hardcoded default port (22) from the set_fact task in tasks/main.yml to defaults/main.yml as bastion_ssh_port_default to improve maintainability and adhere to variable definition best practices.
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: legitYosal The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @legitYosal! |
|
Hi @legitYosal. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
The thing is, this does not remove the default filter (and such case with hostvars can be a acceptable usage, as there is no way to access defaults/vars through hostvars (that I know of) |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
@PangQingcheng: you can only set the release note label to release-note-none if you are the PR author or an org member. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Move the hardcoded default port (22) from the set_fact task in tasks/main.yml to defaults/main.yml as bastion_ssh_port_default to improve maintainability and adhere to variable definition best practices.
What this PR does / why we need it:
#11822
Which issue(s) this PR fixes:
#11822
Fixes #11822
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE