KREP-008: Allow resource references in includeWhen and infer dependencies

[shivansh-source]

proposal fixes #845
I am proposing to treat includeWhen as CEL expressions the same way forEach readyWhen are treated . As input to dependency-graph constructions , not just a runtime conditions.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shivansh-source
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @shivansh-source. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jakobmoellerdev]

conceptually acked, just wondering what the implications on the codebase are. I believe this needs a little discussion on tradeoffs

[shivansh-source]

Where do we discuss about the tradeoffs ?

[jakobmoellerdev]

Where do we discuss about the tradeoffs ?

If you already have an idea of some, then feel free to add them in a dedicated part on KREP, apart from that please join either the community call and ideally also start a slack discussion!

[bschaatsbergen]

Hi @shivansh-source, thanks for working on this!

As part of your KREP, I’d recommend diving a bit deeper into why this currently doesn’t work, why it used to work, and why we need it. That context helps us align on the why before focusing on the how. Right now, I feel the KREP is missing some of that depth. Thanks again!