Skip to content

Conversation

@shivansh-source
Copy link

This PR addresses issue #188 by making instance updates from a
ResourceGraphDefinition (RGD) explicit, traceable, and safe by default.

This PR introduces:

RGD change tracking on instances
Adds two status fields:
resourceRevision: a stable sha256 hash of the compiled graph.Graph
resourceGroupGeneration: a monotonic counter derived from revision changes
These track effective RGD changes without requiring access to Kubernetes metadata.generation
Opt-in update mechanism
Instances only receive RGD updates when annotated with:

kro.run/allow-updates: "true"

By default, updates are blocked and surfaced via conditions
Safe reconciliation behavior
First-time and legacy instances are initialized automatically
Non–opted-in instances are not mutated when the RGD changes
Opted-in instances update normally and refresh their tracked revision/generation.

Testing

Unit tests pass locally

Integration tests require envtest binaries (etcd, kube-apiserver) and were not run locally; CI should execute them

Fixes #188.

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 20, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: shivansh-source / name: shivansh-source (d3092fe)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shivansh-source
Once this PR has been reviewed and has the lgtm label, please assign bridgetkromhout for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @shivansh-source!

It looks like this is your first PR to kubernetes-sigs/kro 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kro has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @shivansh-source. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 20, 2025
@shivansh-source shivansh-source changed the title feature : Track ResourceGraphDefinition changes and require opt-in for instance updates feat : Track ResourceGraphDefinition changes and require opt-in for instance updates Dec 20, 2025
@shivansh-source
Copy link
Author

@a-hilaly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

track ResourceGroup changes and opt-in updates

2 participants