Skip to content

add support for labels and annotations in the generated CRDs#916

Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
cnvergence:add-labels-crd
Jan 22, 2026
Merged

add support for labels and annotations in the generated CRDs#916
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
cnvergence:add-labels-crd

Conversation

@cnvergence
Copy link
Copy Markdown
Member

@cnvergence cnvergence commented Dec 19, 2025

Currently, ResourceGraphDefinitions generate CRDs without user-defined labels or annotations. Adding these would be helpful for users in integrating with kro in their clusters.

This PR will add support for specifying labels and annotations for generated CustomResourceDefinitions in ResourceGraphDefinitions.

Issue:

@cnvergence
add support for labels and annotations in the generated CRDs
b152698 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 19, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 19, 2025

Hi @cnvergence. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2025
@cnvergence cnvergence marked this pull request as ready for review December 19, 2025 20:19
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2025
@a-hilaly
Copy link
Copy Markdown
Member

a-hilaly commented Dec 23, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2025
@a-hilaly a-hilaly added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Dec 23, 2025
jakobmoellerdev
jakobmoellerdev reviewed Dec 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple straightforward addition to the spec imho. from my side good to go!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2025
@cnvergence
Copy link
Copy Markdown
Member Author

cnvergence commented Jan 2, 2026

thanks @jakobmoellerdev!
hopefully the other issue would also be feasible to implement #652

@cnvergence cnvergence mentioned this pull request Jan 2, 2026
Merged
a-hilaly
a-hilaly reviewed Jan 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cnvergence ! left one suggestion below

Comment thread api/v1alpha1/resourcegraphdefinition_types.go
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2026
@cnvergence
group up labels and annotations under CRDMetadata
87d2d97 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
jakobmoellerdev
jakobmoellerdev reviewed Jan 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2026
@a-hilaly
Copy link
Copy Markdown
Member

a-hilaly commented Jan 20, 2026

Could you please update the docs in https://kro.run/docs/concepts/rgd/schema to mention these new fields?

@cnvergence
add docs
ad1f46d 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2026
@cnvergence
Copy link
Copy Markdown
Member Author

cnvergence commented Jan 21, 2026

@a-hilaly added the docs, let me know how they look to you

a-hilaly
a-hilaly approved these changes Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , Thanks @cnvergence !

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, cnvergence

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2026
jakobmoellerdev
jakobmoellerdev reviewed Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks for the contrib!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2026
@k8s-ci-robot k8s-ci-robot merged commit 836bf50 into kubernetes-sigs:main Jan 22, 2026
8 checks passed
@cnvergence cnvergence deleted the add-labels-crd branch January 22, 2026 12:23
@cnvergence cnvergence mentioned this pull request Apr 1, 2026
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@barney-s barney-s Awaiting requested review from barney-s

+1 more reviewer

@jakobmoellerdev jakobmoellerdev jakobmoellerdev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jakobmoellerdev jakobmoellerdev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cnvergence @k8s-ci-robot @a-hilaly @jakobmoellerdev @mirzakopic