WIP: kubeadm v1beta4

[BenTheElder]

fixes #3847

TODO: all of the mess of updating scripts and examples ...

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BenTheElder]

#4046

[BenTheElder]

/test all

[BenTheElder]

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kind/4040/pull-kind-conformance-parallel-ipv6/2008284787059462144

ERROR: failed to create cluster: failed to generate kubeadm config content: failed to parse yaml to patch: failed to parse type meta for "# config generated by kind\napiVersion: kubeadm.k8s.io/v1beta4\nkind: ClusterConfiguration\nmetadata:\n name: config\nkubernetesVersion: v1.36.0-alpha.0.379+b2ac9e206fdd91\nclusterName: "kind"\n\ncontrolPlaneEndpoint: "kind-control-plane:6443"\n# on docker for mac we have to expose the api server via port forward,\n# so we need to ensure the cert is valid for localhost so we can talk\n# to the cluster after rewriting the kubeconfig to point to localhost\napiServer:\n certSANs: [localhost, "::1"]\n extraArgs:\n - name: "runtime-config"\n value: ""\n\ncontrollerManager:\n extraArgs:\n\n - name: "enable-hostpath-provisioner"\n value: "true"\n# configure ipv6 default addresses for IPv6 clusters\n- name: "bind-address"\n value: "::"\nscheduler:\n extraArgs:\n\n# configure ipv6 default addresses for IPv6 clusters\n- name: "bind-address"\n value: "::"\nnetworking:\n podSubnet: "fd00:10:244::/56"\n serviceSubnet: "fd00:10:96::/112"": error converting YAML to JSON: yaml: line 24: did not find expected key

Indentation issue on the bind-address which we only set for ipv6 clusters, issue with converting the template to the new extraArgs format. I think that's fixed now.

[k8s-ci-robot]

@BenTheElder: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kind-conformance-parallel-ipv6	5d9577f	link	true	/test pull-kind-conformance-parallel-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[BenTheElder]

this will need to be updated to something like v1.36.0-0

[BenTheElder]

Ahhh ... that is going to be a problem ...

Because we went from a map to a list "map" for extra args, the patch runtime isn't smart enough to merge them without the user leveraging json6902 patches.

We need something like SMP but without depending on k/k directly ...