Skip to content

feat: Add Chat Completion API support to SharedPrefixDataGenerator #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bongwoobak wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add Chat Completion API support to SharedPrefixDataGenerator #287

bongwoobak wants to merge 2 commits into from
+182 −27

Conversation

@bongwoobak
Copy link

@bongwoobak bongwoobak commented Nov 19, 2025

Summary

Extended SharedPrefixDataGenerator to support Chat Completion API alongside the existing Completion API.

Changes

  • Add Chat Completion API support to SharedPrefixDataGenerator
  • Shared prefix --> system message, question --> user message
  • Backward compatible with existing Completion API

Modified Files

  • inference_perf/datagen/shared_prefix_datagen.py

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bongwoobak
Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 19, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 19, 2025

Welcome @bongwoobak!

It looks like this is your first PR to kubernetes-sigs/inference-perf 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/inference-perf has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 19, 2025
@SachinVarghese
Copy link
Contributor

SachinVarghese commented Nov 20, 2025

/assign @Bslabe123
Make sure compatibility with multi-turn

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2025
@bongwoobak
add chat completion in shared prefix datagen
1fe4026
@bongwoobak
feat: Add Chat API + Multi-turn support
0f0012a 
- Implement UserSessionChatAPIData for Chat API with multi-turn chat
- Update SharedPrefixDataGenerator to support Chat API + Multi-turn combination
- Fix prompt selection to use different questions for each turn
- Initialize user session context as list for Chat API compatibility
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2025
@bongwoobak
Copy link
Author

bongwoobak commented Dec 11, 2025

Sorry for the delay. I've updated the code to support multi-turn chat properly.

@jjk-g
Copy link
Collaborator

jjk-g commented Dec 18, 2025

should fix #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bslabe123 Bslabe123 Awaiting requested review from Bslabe123

@wangchen615 wangchen615 Awaiting requested review from wangchen615

Assignees

@Bslabe123 Bslabe123

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bongwoobak @k8s-ci-robot @SachinVarghese @jjk-g @Bslabe123