-
Notifications
You must be signed in to change notification settings - Fork 219
Preparedata timeout config #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@tsj-30: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tsj-30 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @tsj-30. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind help
/kind test
What this PR does / why we need it:
Wire requestControl.prepareDataTimeout from the EndpointPicker config into the Director’s request-control config.
Allows operators to tune PrepareData plugin timeout globally instead of a fixed 400ms.
Adds a unit test to ensure the timeout is applied during config parsing.
Which issue(s) this PR fixes:
Fixes #2081
Does this PR introduce a user-facing change?:
EPP requestControl prepareDataTimeout is now configurable via the EndpointPicker config.
Tests:
go test ./cmd/epp/runner -run TestParseConfigurationPhaseTwoAppliesPrepareDataTimeout