Skip to content

Conversation

@tsj-30
Copy link
Contributor

@tsj-30 tsj-30 commented Jan 9, 2026

What type of PR is this?
/kind help
/kind test

What this PR does / why we need it:

Wire requestControl.prepareDataTimeout from the EndpointPicker config into the Director’s request-control config.
Allows operators to tune PrepareData plugin timeout globally instead of a fixed 400ms.
Adds a unit test to ensure the timeout is applied during config parsing.
Which issue(s) this PR fixes:
Fixes #2081

Does this PR introduce a user-facing change?:

EPP requestControl prepareDataTimeout is now configurable via the EndpointPicker config.
Tests:

go test ./cmd/epp/runner -run TestParseConfigurationPhaseTwoAppliesPrepareDataTimeout

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 9, 2026
@k8s-ci-robot
Copy link
Contributor

@tsj-30: The label(s) kind/test cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?
/kind feature
/kind test

What this PR does / why we need it:

Wire requestControl.prepareDataTimeout from the EndpointPicker config into the Director’s request-control config.
Allows operators to tune PrepareData plugin timeout globally instead of a fixed 400ms.
Adds a unit test to ensure the timeout is applied during config parsing.
Which issue(s) this PR fixes:
Fixes #2081

Does this PR introduce a user-facing change?:

EPP requestControl prepareDataTimeout is now configurable via the EndpointPicker config.
Tests:

go test ./cmd/epp/runner -run TestParseConfigurationPhaseTwoAppliesPrepareDataTimeout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify
Copy link

netlify bot commented Jan 9, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 7f7b11b
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6960a59a1dbeb50008485bfd
😎 Deploy Preview https://deploy-preview-2111--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tsj-30
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @tsj-30. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow configurable timeouts for PrepareData plugins

2 participants