Skip to content

fix both error propogation and priority band fullness #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Jan 12, 2026
Merged

fix both error propogation and priority band fullness #2103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pkg/epp/handlers/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ func (s *StreamingServer) Process(srv extProcPb.ExternalProcessor_ProcessServer)
break
}

// Body stream complete. Allocate empty slice for response to use.
// Body stream complete. Capture raw size for flow control.
reqCtx.RequestSize = len(body)
body = []byte{}

reqCtx, err = s.director.HandleRequest(ctx, reqCtx)
Expand All @@ -227,12 +228,14 @@ func (s *StreamingServer) Process(srv extProcPb.ExternalProcessor_ProcessServer)
break
}

// Populate the ExtProc protocol responses for the request body.
requestBodyBytes, err := json.Marshal(reqCtx.Request.Body)
// Marshal after HandleRequest to include modifications (e.g., model rewriting).
var requestBodyBytes []byte
requestBodyBytes, err = json.Marshal(reqCtx.Request.Body)
if err != nil {
logger.V(logutil.DEFAULT).Error(err, "Error marshalling request body")
break
}
// Update RequestSize to match marshalled body for Content-Length header.
reqCtx.RequestSize = len(requestBodyBytes)
reqCtx.reqHeaderResp = s.generateRequestHeaderResponse(reqCtx)
reqCtx.reqBodyResp = s.generateRequestBodyResponses(requestBodyBytes)
Expand Down