-
Notifications
You must be signed in to change notification settings - Fork 219
feat: Change epp to be its standalone helm chart and inferencePool be its parent chart
#2089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Change epp to be its standalone helm chart and inferencePool be its parent chart
#2089
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: capri-xiyue The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I sent this early so that @LukeAVanDrie can check why the pod locator break the epp standalone logic. |
|
/unblock |
|
/unhold |
epp to be its standalone helm chart and inferencePool be its parent chart
epp to be its standalone helm chart and inferencePool be its parent chartepp to be its standalone helm chart and inferencePool be its parent chart
|
@ahg-g @kfswain This change brought some break changes when users install |
|
/assign @ahg-g |
|
/assign @kfswain |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This refactor is not backward compatible, it will break existing guides as well as llm-d charts that import the infPool one |
Discussed offline, helm suggested approach I will investigate other hacky ways to shared values without |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Refactor
eppto be its standalone helm chart andinferencePoolbe its parent chart. I followed the helm practise https://helm.sh/docs/chart_template_guide/subcharts_and_globals/ here.See #2063
Which issue(s) this PR fixes:
Fixes #2063
Does this PR introduce a user-facing change?: