Skip to content

Conversation

@AvineshTripathi
Copy link
Contributor

Previously, setupInfra used kustomize to create CRDs from config/crd/, but the cleanup logic only deleted specific CRDs. This left dangling CRDs in the cluster, making it difficult to re-run tests.

Refactor CreateCrdsFromKustomize to accept an action callback and introduce DeleteAndVerifyObjs. This enables using the same Kustomize configuration to properly identify and delete all created CRDs during cleanup.

/kind test

Added DeleteAndVerifyObjs and updated CreateCrdsFromKustomize to accept an action callback, enabling reuse for both creation and deletion workflows. Also exported CreateAndVerifyObjs for broader usage.

Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
@k8s-ci-robot
Copy link
Contributor

@AvineshTripathi: The label(s) kind/test cannot be applied, because the repository doesn't have them.

Details

In response to this:

Previously, setupInfra used kustomize to create CRDs from config/crd/, but the cleanup logic only deleted specific CRDs. This left dangling CRDs in the cluster, making it difficult to re-run tests.

Refactor CreateCrdsFromKustomize to accept an action callback and introduce DeleteAndVerifyObjs. This enables using the same Kustomize configuration to properly identify and delete all created CRDs during cleanup.

/kind test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify
Copy link

netlify bot commented Dec 22, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 7e5510c
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6949724d1802e6000895958e
😎 Deploy Preview https://deploy-preview-2033--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AvineshTripathi
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @AvineshTripathi. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants