Separate conformance tests modules from main tests #1994
Conversation
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
size/L
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/cc @jaellio |
|
@rikatz: GitHub didn't allow me to request PR reviews from the following users: jaellio. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
<3 <3 <3 /approve I see a hold on here, so will hold off on LGTM and let others give final stamp. But this is great. Thank you so much! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
a heads up I didn't had time to tackle, https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/.github/dependabot.yml may need some updates as well (as @mikemorris also identified on GW API today). If no one arrives on this PR by tomorrow I will try to fix it, otherwise I can do as a followup |
conformance/go.mod
Outdated
| replace sigs.k8s.io/gateway-api-inference-extension => ../ | ||
|
|
||
| require ( | ||
| sigs.k8s.io/gateway-api v1.3.1-0.20251106052652-079e4774d76b |
There was a problem hiding this comment.
Can we update this to the latest version (1.4)?
There was a problem hiding this comment.
@jaellio updating the Gateway API version kinds of break the conformance because creq.HTTPPort is not available. I will check which commit removed it and what this was replaced for, but maybe it is worth doing on a different PR? Otherwise I can do it :)
There was a problem hiding this comment.
Actually I can see this is at main and even being called v1.3.1 it is indeed pointing to a commit from monthly release (https://github.com/kubernetes-sigs/gateway-api/releases/tag/monthly-2025.12) so we may be good to go
There was a problem hiding this comment.
@rikatz An inspection of the https://github.com/kubernetes-sigs/gateway-api at tag v1.4.1 shows that commit kubernetes-sigs/gateway-api@079e477 is indeed merged in that release
There was a problem hiding this comment.
Hum I just checked the tag: https://github.com/kubernetes-sigs/gateway-api/blob/v1.4.1/conformance/echo-basic/echo-basic.go
It is tagged as monthly, but not as 1.4.1
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
the
needs-rebase
rikatz
force-pushed
the
separate-modules
branch
from
33ac56f to
14cb578
Compare
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
lgtm
rikatz
force-pushed
the
separate-modules
branch
from
14cb578 to
7af27ee
Compare
|
Done again. As a suggestion, you may want to separate all of the BBR, EPP code (and packages) from the main API, otherwise someone consuming GIE API will get the whole go.mod from the main directory. |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Separate conformance test modules from main modules, removing the dependency of Gateway API version.
Which issue(s) this PR fixes: