Skip to content

BBR pluggable framework proposal #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
davidbreitgand wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BBR pluggable framework proposal #1964

davidbreitgand wants to merge 1 commit into from

Conversation

@davidbreitgand
Copy link
Contributor

@davidbreitgand davidbreitgand commented Dec 7, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1963

This is a design proposal PR, it does not introduce code changes.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 7, 2025
@netlify
Copy link

netlify bot commented Dec 7, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 3e004a7
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/695d7f484dccd70008af0486
😎 Deploy Preview https://deploy-preview-1964--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidbreitgand
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 7, 2025

Hi @davidbreitgand. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 7, 2025
@davidbreitgand davidbreitgand mentioned this pull request Dec 7, 2025
Open
@davidbreitgand davidbreitgand changed the title Bbr pluggable framework proposal [WIP] Bbr pluggable framework proposal Dec 7, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2025
@davidbreitgand davidbreitgand marked this pull request as draft December 7, 2025 19:20
@davidbreitgand davidbreitgand changed the title [WIP] Bbr pluggable framework proposal BBR pluggable framework proposal Dec 12, 2025
@davidbreitgand davidbreitgand force-pushed the bbr-pluggable-proposal branch 2 times, most recently from cd109fd to 9b24a69 Compare December 12, 2025 14:33
@davidbreitgand davidbreitgand marked this pull request as ready for review December 12, 2025 14:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2025
@davidbreitgand
Copy link
Contributor Author

davidbreitgand commented Dec 12, 2025 •
edited
Loading

@srampal , @elevran , @nirrozenbaum could you please review?

Initial implementation: PR 1981

will be refactored into a series of smaller PRs to fit the phased scope of the proposal.

@davidbreitgand davidbreitgand mentioned this pull request Dec 14, 2025
Open
elevran
elevran reviewed Dec 15, 2025
View reviewed changes
docs/proposals/1964-pluggable-bbr-framework/README.md Outdated
const (
//A deafult plugin implementation of this plugin type will always be configured for request plugins chain
//Even though BBRPlugin type is not (yet) a K8s resource, it's logically akin to `kind`
//MUST start wit an upper case letter, use CamelNotation, only aplhanumericals after the first letter
Copy link
Contributor

@elevran elevran Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//MUST start wit an upper case letter, use CamelNotation, only aplhanumericals after the first letter
// MUST start with an upper case letter, use CamelNotation, only aplhanumericals after the first letter

elevran
elevran reviewed Dec 15, 2025
View reviewed changes
docs/proposals/1964-pluggable-bbr-framework/README.md Outdated
The pluggable framework will be implemented iteratively over several phases.

1. Introduce `BBRPlugin` `MetadataExtractor`, interface, registry, plugins chain, sample plugin implementation (`SimpleModelExtraction`) and its factory. Plugin configuration will be implemented via environment variables set in helm chart
1. Introduce a second plugin interface, `ModelSelector` and sample plugin implementation
Copy link
Contributor

@elevran elevran Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: for the initial task (various ways to do body based routing), a ModelSelector interface would have been sufficient. Why do we need multiple interfaces and what's the delta between interface in (1) and in (2)?

docs/proposals/1964-pluggable-bbr-framework/README.md Outdated

1. Introduce `BBRPlugin` `MetadataExtractor`, interface, registry, plugins chain, sample plugin implementation (`SimpleModelExtraction`) and its factory. Plugin configuration will be implemented via environment variables set in helm chart
1. Introduce a second plugin interface, `ModelSelector` and sample plugin implementation
1. Introduce shared struct (shared among the plugins of a plugins chain)
Copy link
Contributor

@elevran elevran Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that does what?

Copy link
Contributor Author

@davidbreitgand davidbreitgand Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ModelSelector is aimed at semantic model selection rather than simple metadata extraction and putting it on the headers.

srampal
srampal reviewed Dec 17, 2025
View reviewed changes
Copy link
Contributor

@srampal srampal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments for now. Review is ongoing so maybe more to come.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2026
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 6, 2026
@davidbreitgand davidbreitgand force-pushed the bbr-pluggable-proposal branch from 1395c8c to c4f9775 Compare January 6, 2026 17:00
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 6, 2026
@davidbreitgand
Copy link
Contributor Author

davidbreitgand commented Jan 6, 2026

Hi @nirrozenbaum 👋
Could you please review this PR when you have a chance?
All reviewers' comments and feedback have been addressed, commits have been squashed into one, and the branch is up to date with main.
If everything looks good, feel free to merge. Thanks!

@davidbreitgand davidbreitgand force-pushed the bbr-pluggable-proposal branch from c4f9775 to 663ccb4 Compare January 6, 2026 21:23
@davidbreitgand davidbreitgand force-pushed the bbr-pluggable-proposal branch from 663ccb4 to 3e004a7 Compare January 6, 2026 21:31
@kfswain
Copy link
Collaborator

kfswain commented Jan 8, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kfswain kfswain Awaiting requested review from kfswain

@shmuelk shmuelk Awaiting requested review from shmuelk

@ahg-g ahg-g Awaiting requested review from ahg-g

@liu-cong liu-cong Awaiting requested review from liu-cong

2 more reviewers

@srampal srampal srampal left review comments

@elevran elevran elevran left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidbreitgand @k8s-ci-robot @kfswain @srampal @elevran