-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore(source): standardize sources #6089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore(source): standardize sources #6089
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 20855079367Details
💛 - Coveralls |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
What does it do ?
This PR standardizes controller mismatch checking and empty endpoint logging across all source implementations by extracting duplicated logic into reusable helper functions.
New helper functions
endpoint.HasEmptyEndpoints()(file created endpoint/utils.go similar to source/utils.go)- Checks if endpoint list is empty and logs a standardized debug message
- Returns true if empty, false otherwise
annotations.IsControllerMismatch()(source/annotations/processors.go)- Checks if a resource should be skipped due to controller annotation not matching
- Logs a standardized debug message when skipping
Motivation
More