Skip to content

Bump Golang version to v1.25.0#225

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
RainbowMango:pr_bump_golang125
Jan 22, 2026
Merged

Bump Golang version to v1.25.0#225
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
RainbowMango:pr_bump_golang125

Conversation

@RainbowMango
Copy link
Copy Markdown
Member

This PR bumps Golang to v1.25.0 as it is necessary before bumping Kubernetes v1.35.
See #224 (comment) for reference.

Copilot AI review requested due to automatic review settings January 6, 2026 09:09
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If custom-metrics-apiserver contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 6, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Instrumentation Jan 6, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go language version from 1.24.0 to 1.25.0 and the toolchain from go1.24.4 to go1.25.5. This upgrade is stated as a prerequisite for bumping Kubernetes dependencies to v1.35, as referenced in the related PR #224 for updating k8s-dependencies.

Key Changes:

  • Go version bumped from 1.24.0 to 1.25.0
  • Toolchain version bumped from go1.24.4 to go1.25.5

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RainbowMango
Copy link
Copy Markdown
Member Author

/retest

@RainbowMango
Copy link
Copy Markdown
Member Author

Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.5)
Failed executing command with error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.5)
Run "make update-lint"
make: *** [Makefile:60: verify-lint] Error 1

Will fix this later.

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango RainbowMango added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2026
@k8s-ci-robot k8s-ci-robot merged commit 1bbd810 into kubernetes-sigs:master Jan 22, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in SIG Instrumentation Jan 22, 2026
@RainbowMango RainbowMango deleted the pr_bump_golang125 branch January 22, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants