✨ Disable DWARF and symbol table to decrease binary/image size#12856
✨ Disable DWARF and symbol table to decrease binary/image size#12856k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Conversation
e8d6c73 to
4fbbc69
Compare
|
/area misc |
|
Thx for the PR. I want to do some due diligence before merging it. Just probably won't find time to do it any time soon |
|
/retest |
1 similar comment
|
/retest |
|
@sbueringer Please take a look when you have time. |
|
Yup, will do! |
|
Please also rebase onto latest main |
4fbbc69 to
2730043
Compare
2730043 to
4dd5860
Compare
|
Thank you very much, especially for the patience! Sorry for the delay /lgtm |
|
LGTM label has been added. DetailsGit tree hash: 8b722169a8af4a1fd50197b70087e4ebe997f62e |
|
/hold |
4dd5860 to
c664837
Compare
This commit introduces DBG variable which is used to control including DWARF and symbol table for images/binaries Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
c664837 to
a785807
Compare
|
Thx again! /lgtm |
|
LGTM label has been added. DetailsGit tree hash: 44bbfc889f1e98450e524a1b129ee3947353a640 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR removes DWARF and symbol table from binaries by default and introduces an option including them by setting
DBG=1.Current images
After removing DWARF and symbol table
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
#12855