feat(ingress): add frontend-nlb-attribtues annotation for ingress by swarner1033 · Pull Request #4380 · kubernetes-sigs/aws-load-balancer-controller

swarner1033 · 2025-10-07T09:41:28Z

Issue

#4333

Description

Add the frontend-nlb-attributes annotation to enable you to set deletion protection, cross zone load balancing ect
Fix typo Alloactions -> Allocations
Abstract out LB constants and makeAttributesSliceFromMap() also used in model build load balancer into the shared packages.

Checklist

Added tests that cover your change (if possible)
Added/modified documentation as required (such as the README.md, or the docs directory)
Manually tested
Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Backfilled missing tests for code in same general area 🎉
Refactored something and made the world a better place 🌟

k8s-ci-robot · 2025-10-07T09:41:39Z

Hi @swarner1033. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

swarner1033 · 2025-11-11T07:04:17Z

Hi @M00nF1sh @zac-nixon

I know it says XL but I've really just abstracted out a some functionality so that I can reuse it. Haven't actually made an XL change.

swarner1033 · 2026-01-20T06:51:50Z

Now that its the new year it would be great to get this merged @oliviassss @wweiwei-li @M00nF1sh @zac-nixon

I could move the abstraction so that the bot would grade it as a smaller change but I believe this would be a worse solution as it would result in two pieces of similar code to maintain.

shraddhabang · 2026-01-20T20:13:38Z

/ok-to-test

shraddhabang · 2026-01-26T18:39:29Z

        - enable access log to s3
        ```
-        service.beta.kubernetes.io/aws-load-balancer-attributes: access_logs.s3.enabled=true,access_logs.s3.bucket=my-access-log-bucket,access_logs.s3.prefix=my-app
+        alb.ingress.kubernetes.io/aws-load-balancer-attributes: access_logs.s3.enabled=true,access_logs.s3.bucket=my-access-log-bucket,access_logs.s3.prefix=my-app


You are still referring to ingress specific annotations alb.ingress.kubernetes.io/aws-load-balancer-attributes instead of frontend-nlb-attributes annotations. alb.ingress.kubernetes.io/frontend-nlb-attributes. The example should reflect how to set attributes on your frontend NLB.

sorry fixed

swarner1033 · 2026-02-17T22:10:38Z

@shraddhabang thanks for your feedback. Was there anything else or are we good to merge?

sophie-warner-annalise-ai · 2026-03-03T06:38:13Z

Anyone else have the time to approve? Doc feedback has been fixed
@oliviassss @wweiwei-li @M00nF1sh @zac-nixon

wweiwei-li · 2026-03-03T17:05:41Z

/lgtm
/Approved

wweiwei-li · 2026-03-03T17:06:28Z

/ok-to-test

shraddhabang · 2026-03-03T18:51:54Z

/lgtm

wweiwei-li · 2026-03-03T18:55:08Z

/Approved

k8s-ci-robot · 2026-03-03T18:57:02Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: swarner1033

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 7, 2025

k8s-ci-robot requested review from oliviassss and wweiwei-li October 7, 2025 09:41

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 7, 2025

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 7, 2025

swarner1033 changed the title ~~Feat/4333 attributes flb~~ feat(ingress): add frontend-nlb-attribtues annotation for ingress #4333 Oct 7, 2025

swarner1033 changed the title ~~feat(ingress): add frontend-nlb-attribtues annotation for ingress #4333~~ feat(ingress): add frontend-nlb-attribtues annotation for ingress Oct 7, 2025

swarner1033 marked this pull request as ready for review October 7, 2025 10:03

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2025

k8s-ci-robot requested review from M00nF1sh and zac-nixon October 7, 2025 10:03

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2025

swarner1033 force-pushed the feat/4333-attributes-flb branch from c732db8 to bc73b9c Compare November 11, 2025 07:00

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2025

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2025

swarner1033 added 12 commits January 20, 2026 17:42

refactor(service): move attribute slice func to shared utils

d031e60

refactor(nlb): move constants to shared constants file

4362baf

fix(ingress): correct types for getFrontendNlbAttributes

124d373

fix(ingress): existing tests pass

c810bb3

test(ingress): first draft for all attributes

0ac633f

feat(ingress): add required annotation

78f4337

docs(*): start updating for fnlb attributes

ae8a350

test(ingress): wrong annotation name

942c852

test(shared utils): write for nlb utils

52d148b

docs(ingress): add section for frontend NLB attributes

570a8c9

tests(ingress): remove envoloping tests

c6376db

chore(service): clean up for pr

dd0a310

swarner1033 force-pushed the feat/4333-attributes-flb branch from bc73b9c to dd0a310 Compare January 20, 2026 06:45

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2026

shraddhabang reviewed Jan 20, 2026

View reviewed changes

Comment thread docs/guide/ingress/annotations.md Outdated

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2026

docs(ingress): copy pasta service, should be ingress

f34c8af

shraddhabang reviewed Jan 26, 2026

View reviewed changes

docs(ingress): reference correct attribute with correct prefix

06daf43

sophie-warner-annalise-ai mentioned this pull request Feb 20, 2026

EIP allocation for frontend NLBs #4300

Open

2 tasks

k8s-ci-robot assigned wweiwei-li Mar 3, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2026

k8s-ci-robot assigned shraddhabang Mar 3, 2026

wweiwei-li added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026

k8s-ci-robot merged commit ff91613 into kubernetes-sigs:main Mar 3, 2026
5 checks passed

zac-nixon mentioned this pull request Apr 6, 2026

🥳 aws-load-balancer-controller v3.2.0 Automated Release! 🥑 aws/eks-charts#1315

Merged

Conversation

swarner1033 commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Description

Checklist

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Uh oh!

k8s-ci-robot commented Oct 7, 2025

Uh oh!

swarner1033 commented Nov 11, 2025

Uh oh!

swarner1033 commented Jan 20, 2026

Uh oh!

Uh oh!

shraddhabang commented Jan 20, 2026

Uh oh!

shraddhabang Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

swarner1033 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

swarner1033 commented Feb 17, 2026

Uh oh!

sophie-warner-annalise-ai commented Mar 3, 2026

Uh oh!

wweiwei-li commented Mar 3, 2026

Uh oh!

wweiwei-li commented Mar 3, 2026

Uh oh!

shraddhabang commented Mar 3, 2026

Uh oh!

wweiwei-li commented Mar 3, 2026

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

swarner1033 commented Oct 7, 2025 •

edited

Loading