add analytics guide #184
add analytics guide #184
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: drogovozDP The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for agent-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @drogovozDP. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/XXL
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| fsGroup: 2000 | ||
| containers: | ||
| - name: python-sandbox | ||
| image: us-docker.pkg.dev/<PROJECT_ID>/analytics/analytics-tool:1.0.0 |
There was a problem hiding this comment.
Use the bash format please.
us-docker.pkg.dev/$PROJECT_ID/analytics/analytics-tool:1.0.0
examples/analytics-tool/README.md
Outdated
| --description="Analytics Repo" | ||
| ``` | ||
|
|
||
| And now we can create our analytics agent-sandbox tool: |
There was a problem hiding this comment.
Prevent using the words: And now, our. Instead structure it as bullet points.
- Create a repository in Artifact Registry.
- Create analytics agent-sandbox.
- Deploy the changes.
There was a problem hiding this comment.
Paraphrased all "we", "our", and "you" moments
examples/analytics-tool/README.md
Outdated
| print(f"<IMG>{img_str}</IMG>") | ||
| ``` | ||
|
|
||
| As you can see, in the end the code prints an encoded image. Inside the tool definition we use the regex expression to extract this string, decode, and plot it. |
There was a problem hiding this comment.
Can we add a sample output of how it will look like?
| """ | ||
| try: | ||
| # Split the command string into a list to safely pass to subprocess | ||
| args = shlex.split(request.command) |
There was a problem hiding this comment.
Validation to check malformed commands?
| args, | ||
| capture_output=True, | ||
| text=True, | ||
| cwd="/app" |
There was a problem hiding this comment.
Consider adding a timeout.
4 participants
No description provided.